zinovy.nis marked 2 inline comments as done.
zinovy.nis added a comment.
Hope I satisfied all your requests now.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
phosek updated this revision to Diff 138882.
phosek marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D39930
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
Index: clang/cmake/caches/Fuchsia-stage2.cmake
=
sepavloff added a comment.
Good catch, thank you.
To avoid code duplication you could change `InsertionPoint` into an index and
use `begin() + InsertionPoint` in calls to `insert`.
Repository:
rC Clang
https://reviews.llvm.org/D44607
___
cfe-co
marcan updated this revision to Diff 13.
Repository:
rC Clang
https://reviews.llvm.org/D44607
Files:
tools/driver/driver.cpp
Index: tools/driver/driver.cpp
===
--- tools/driver/driver.cpp
+++ tools/driver/driver.cpp
@@ -21
SjoerdMeijer updated this revision to Diff 138890.
SjoerdMeijer retitled this revision from "[ARM] Add HasFloat16 to TargetInfo"
to "[ARM] Pass half or i16 types for NEON intrinsics".
SjoerdMeijer added a comment.
Herald added a subscriber: rengolin.
Removed unused function argument, and renamed
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Thanks. I think this looks reasonable now.
https://reviews.llvm.org/D44561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yvvan added a comment.
Ping
https://reviews.llvm.org/D41537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdardis added a comment.
Ping?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dfukalov added a comment.
> My real question was what happens if you put 11 in the description string?
in this case CanT.getAddressSpace() returns target addrspace value "20" (also
shifted in the enum by 9==LangAS::FirstTargetAddressSpace)
So again ASTContext::getAddrSpaceQualType decieds that
ioeric added a comment.
lgtm
(Please add reviewers to your patch if you intend it to be reviewed.)
Comment at: clangd/CMakeLists.txt:7
+if(NOT HAVE_CXX_ATOMICS64_WITHOUT_LIB)
+ list(APPEND CLANGD_ATOMIC_LIB atomic)
+endif()
nit: s/atomic/"atomic"/
Repositor
sdardis added a comment.
Thanks, I wasn't sure who to add as a reviewer.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
SjoerdMeijer added a comment.
Thanks a lot for your help and reviews.
https://reviews.llvm.org/D44561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Ping.
https://reviews.llvm.org/D44155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nhaehnle added a comment.
Is that compiler really supported? Look at this:
void operator delete(void *) = delete;
It's been there in the code since early 2015. The bitwise OR on ELF::xxx has
been there even longer.
Are you telling me that we officially support a compiler, but nobody has
ac
QF5690 added reviewers: aaron.ballman, benhamilton.
QF5690 added a comment.
Hey, saw many revisions around obj-c and sema that you are reviewing. Can you
help me with this one?
Repository:
rC Clang
https://reviews.llvm.org/D44539
___
cfe-commits
yvvan added a comment.
@nhaehnle And that's the problem. There's no build machine for intel compiler
and nobody cares.
And if somebody like me want to build it - there's no solution rather than
searching for workarounds yourself.
This patch is not that complex in the end as you see so it should
lebedev.ri added a comment.
Please upload patches with full context (`-U9`) :)
https://reviews.llvm.org/D44155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman updated this revision to Diff 138900.
aaron.ballman added a comment.
Now: with more context!
https://reviews.llvm.org/D44155
Files:
lib/Analysis/ThreadSafety.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn-thread-safety-analysis.cpp
aaron.ballman added a comment.
In https://reviews.llvm.org/D44155#1041584, @lebedev.ri wrote:
> Please upload patches with full context (`-U9`) :)
Ugh, yes. TortoiseSVN has no option for this, so I perpetually forget.
https://reviews.llvm.org/D44155
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327833: [clang-tidy] New check bugprone-unused-return-value
(authored by alexfh, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.llvm.org/D41655?
Author: alexfh
Date: Mon Mar 19 06:02:32 2018
New Revision: 327833
URL: http://llvm.org/viewvc/llvm-project?rev=327833&view=rev
Log:
[clang-tidy] New check bugprone-unused-return-value
Summary:
Detects function calls where the return value is unused.
Checked functions can be configured.
Reviewe
sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.
LGTM.
Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D44607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
Tests?
Repository:
rC Clang
https://reviews.llvm.org/D44588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: sjoerdmeijer
Date: Mon Mar 19 06:22:49 2018
New Revision: 327836
URL: http://llvm.org/viewvc/llvm-project?rev=327836&view=rev
Log:
[ARM] Pass half or i16 types for NEON intrinsics
For generating NEON intrinsics, this determines the NEON data type, and whether
it should be a half type or a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327836: [ARM] Pass half or i16 types for NEON intrinsics
(authored by SjoerdMeijer, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44561?vs=1
marcan added a comment.
Note that I don't have commit access, so someone else will have to commit it
for me :)
Repository:
rC Clang
https://reviews.llvm.org/D44607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Self-LGTMing since it's a trivial follow-up to an accepted change.
https://reviews.llvm.org/D36828
___
cfe-commits mailing list
cfe
Author: bjope
Date: Sun Mar 18 09:07:20 2018
New Revision: 327802
URL: http://llvm.org/viewvc/llvm-project?rev=327802&view=rev
Log:
Resolve unused variable 'VR' warning in RetainCountChecker.cpp
Getting rid of
error: unused variable 'VR' [-Werror,-Wunused-variable]
warning/error at
lib/Static
SjoerdMeijer abandoned this revision.
SjoerdMeijer added a comment.
This is implemented in https://reviews.llvm.org/D44591.
https://reviews.llvm.org/D44222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
This looks good to me, but we need a companion LLVM patch and add codegen tests
for this to: CodeGen/AArch64/fp16_intrinsic_lane.ll.
https://reviews.llvm.org/D44591
___
courbet updated this revision to Diff 138910.
courbet added a comment.
Herald added a subscriber: cfe-commits.
Do not trigger on `some_int += std::floor(some_float)`;
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38455
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327852: Updated a usage of createTemporaryFile that does not
expect file to be created. (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revi
Author: ibiryukov
Date: Mon Mar 19 07:20:25 2018
New Revision: 327852
URL: http://llvm.org/viewvc/llvm-project?rev=327852&view=rev
Log:
Updated a usage of createTemporaryFile that does not expect file to be created.
Summary:
This fixes a usage of createTemporaryFile in clang repo after
a change i
sepavloff added a comment.
Other compilers successfully recognize errors (checked using
https://godbolt.org/). For instance, the code:
template inline void func_35(T *x);
template
struct C35a {
template friend void func_35(T *x) {}
};
template
struct C35b {
template friend vo
gtbercea abandoned this revision.
gtbercea added a comment.
After some internal discussion with @ABataev he is going to replace the manual
computation of the thread ID with a call to the runtime in a new patch.
Repository:
rC Clang
https://reviews.llvm.org/D44588
_
Author: vmiklos
Date: Mon Mar 19 07:43:59 2018
New Revision: 327854
URL: http://llvm.org/viewvc/llvm-project?rev=327854&view=rev
Log:
run-clang-tidy: forward clang-tidy exit status
Exit with a non-zero value in case any of the underlying clang-tidy
invocations exit with a non-zero value.
This is
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327854: run-clang-tidy: forward clang-tidy exit status
(authored by vmiklos, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44366
ilya-biryukov added a subscriber: simark.
ilya-biryukov added a comment.
Found by @simark while working on https://reviews.llvm.org/D44272.
Repository:
rC Clang
https://reviews.llvm.org/D44628
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: alexfh.
ilya-biryukov added a subscriber: simark.
ilya-biryukov added a comment.
Found by @simark while working on https://reviews.llvm.org/D44272.
LLVM .clang_tidy seems to be more up-to-date.
Repository:
rC Clang
https:/
juliehockett added a comment.
I was just thinking of disabling the one test that has an issue
(class-in-function) on Windows -- the filename is only used in generating
*some* USRs, so all of the other ones are fine. We ran into some issues with
that though, since `UNSUPPORTED: system-windows` d
Author: phosek
Date: Mon Mar 19 08:19:19 2018
New Revision: 327860
URL: http://llvm.org/viewvc/llvm-project?rev=327860&view=rev
Log:
[CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain
Fuchsia already defaults to libc++ and compiler-rt, but we want to use
these as default
lebedev.ri added a comment.
In https://reviews.llvm.org/D41102#1041773, @juliehockett wrote:
> I was just thinking of disabling the one test that has an issue
> (class-in-function) on Windows -- the filename is only used in generating
> *some* USRs, so all of the other ones are fine. We ran int
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327860: [CMake] Use libc++ and compiler-rt as default
libraries in Fuchsia toolchain (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D39930?vs=138882&id=138936#toc
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1041791, @lebedev.ri wrote:
> Have you tried something more broad, like
> `UNSUPPORTED: mingw32,win32`
> ?
That wasn't working either, confusingly, at least on the local windows machine
I have.
Repository:
rL LLVM
https://
hans created this revision.
hans added reviewers: thakis, rnk.
This allows users to turn off warnings about this pragma specifically, while
still receiving warnings about other ignored pragmas.
https://reviews.llvm.org/D44630
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Bas
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:164
+ if (!Contents) {
+log(llvm::toString(Contents.takeError()));
+return;
We should signal an error to the client by calling `replyError`
Comment at: clangd/
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This addresses bug 36766 and a FIXME in tests about empty lines before
`}[;] // comment` lines.
Repository:
rC Clang
https://reviews.llvm.org/D44631
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Form
Author: krasimir
Date: Mon Mar 19 08:33:40 2018
New Revision: 327861
URL: http://llvm.org/viewvc/llvm-project?rev=327861&view=rev
Log:
[clang-format] Remove empty lines before }[;] // comment
Summary:
This addresses bug 36766 and a FIXME in tests about empty lines before
`}[;] // comment` lines.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327861: [clang-format] Remove empty lines before }[;] //
comment (authored by krasimir, committed by ).
Changed prior to
benhamilton created this revision.
benhamilton added reviewers: jolesiak, djasper.
Herald added subscribers: cfe-commits, klimek.
We received reports of the Objective-C style guesser getting a false
negative on header files like:
CGSize SizeOfThing(MyThing thing);
This adds more Core Graphics id
simark requested changes to this revision.
simark added inline comments.
This revision now requires changes to proceed.
Comment at: .clang-tidy:8
- key: readability-identifier-naming.FunctionCase
-value: lowerCase
+value: camelBack
+ -
ilya-biryukov added a comment.
Sorry for the delay.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:565
+ /// \brief For this completion result correction is required.
+ Optional Corr = None;
+
Having a string replacement without an actual range to repl
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Comment at: lib/Parse/ParsePragma.cpp:2970
+
+ if (Tok.isNot(tok::l_paren)) {
+PP.Diag(Tok.getLocation(), diag::warn_pragma_expected_lparen) <<
"optimize";
aprantl added a comment.
I should also point out that even in DWARF v5 mode LLVM does not yet emit DWARF
5 variants of all sections as DWARF v5 support in LLVM is not yet
feature-complete.
Repository:
rC Clang
https://reviews.llvm.org/D44605
__
lebedev.ri added a comment.
Huh, something weird is going on there.
What about the other way around, `REQUIRES: linux` ?
Repository:
rL LLVM
https://reviews.llvm.org/D41102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
simark marked 4 inline comments as done.
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:164
+ if (!Contents) {
+log(llvm::toString(Contents.takeError()));
+return;
ilya-biryukov wrote:
> We should signal an error to the client by ca
ioeric added a comment.
In https://reviews.llvm.org/D44248#1041531, @sdardis wrote:
> Thanks, I wasn't sure who to add as a reviewer.
Authors/reviewers of recent patches for the same files are usually good
approximations :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D4424
Author: sepavloff
Date: Mon Mar 19 09:13:43 2018
New Revision: 327863
URL: http://llvm.org/viewvc/llvm-project?rev=327863&view=rev
Log:
[Driver] Avoid invalidated iterator in insertTargetAndModeArgs
Doing an .insert() can potentially invalidate iterators by reallocating the
vector's storage. When
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327863: [Driver] Avoid invalidated iterator in
insertTargetAndModeArgs (authored by sepavloff, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
benhamilton created this revision.
benhamilton added reviewers: jolesiak, djasper.
Herald added subscribers: cfe-commits, klimek.
Previously, the Objective-C heuristic failed to detect
headers which #imported Objective-C system framework(s) and declared C
functions on top them.
This extends the h
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:330
+ nonloc::ConcreteInt(Max), SVB.getConditionType());
+ if (auto DV = IsCappedFromAbove.getAs()) {
+if (State->assume(*DV, false))
geo
baloghadamsoftware updated this revision to Diff 138954.
baloghadamsoftware added a comment.
Updated according to the comments.
https://reviews.llvm.org/D41938
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/Si
erichkeane added a comment.
Adding @mibintc to take a look, as she's a good representative of the ICC dev
team.
https://reviews.llvm.org/D44426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
baloghadamsoftware marked 12 inline comments as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:326
+
+ llvm::APSInt Max = AT.getMaxValue() >> 2; // Divide by 4.
+ SVal IsCappedFromAbove =
george.karpenk
Author: abataev
Date: Mon Mar 19 10:04:07 2018
New Revision: 327867
URL: http://llvm.org/viewvc/llvm-project?rev=327867&view=rev
Log:
[OPENMP, NVPTX] Emit correct thread id.
We emitted fake thread id for the outined function in NVPTX codegen.
Patch adds emission of the real thread id.
Modified:
Thanks!
Reid Kleckner via cfe-commits writes:
> Author: rnk
> Date: Fri Mar 16 13:36:49 2018
> New Revision: 327738
>
> URL: http://llvm.org/viewvc/llvm-project?rev=327738&view=rev
> Log:
> [MS] Don't escape MS C++ names with \01
>
> It is not needed after LLVM r327734. Now it will be easier to
benhamilton added a comment.
I wonder if this wouldn't be better as a clang-tidy check:
https://github.com/llvm-mirror/clang-tools-extra/tree/master/clang-tidy/objc
Repository:
rC Clang
https://reviews.llvm.org/D44539
___
cfe-commits mailing lis
Author: abataev
Date: Mon Mar 19 10:18:13 2018
New Revision: 327868
URL: http://llvm.org/viewvc/llvm-project?rev=327868&view=rev
Log:
[OPENMP] Fix build with MSVC, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
URL:
htt
simark marked 3 inline comments as done.
simark added inline comments.
Comment at: clangd/DraftStore.cpp:61
+ const Position &Start = Change.range->start;
+ size_t StartIndex = positionToOffset(Contents, Start);
+ if (StartIndex > Contents.length()) {
-
Author: ahatanak
Date: Mon Mar 19 10:38:40 2018
New Revision: 327870
URL: http://llvm.org/viewvc/llvm-project?rev=327870&view=rev
Log:
[ObjC] Allow declaring __weak pointer fields in C structs in ARC.
This patch uses the infrastructure added in r326307 for enabling
non-trivial fields to be declar
ahatanak added a comment.
This was reverted in r327294 because it caused module-enabled builders to fail
after I moved CXXRecordDecl::CanPassInRegisters to RecordDecl. I'm recommitting
this patch with fixes to ASTDeclReader and ASTWriter.
Repository:
rC Clang
https://reviews.llvm.org/D44095
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Code looks good, but we should make the test more robust and self-documenting.
Comment at: test/CodeGenCXX/inheriting-constructor-cleanup.cpp:22
+// CHECK-LABEL: define void @_Z1fv
Author: abataev
Date: Mon Mar 19 10:53:56 2018
New Revision: 327873
URL: http://llvm.org/viewvc/llvm-project?rev=327873&view=rev
Log:
[OPENMP, NVPTX] Reworked castToType() function, NFC.
Reworked function castToType to use more frontend functionality rather
than the backend.
Modified:
cfe/tr
benhamilton created this revision.
benhamilton added reviewers: jolesiak, djasper, Wizard.
Herald added subscribers: cfe-commits, klimek.
Objective-C selectors can with arguments be in the form:
foo:
foo:bar:
foo:bar:baz:
These can be passed to a macro, like NS_SWIFT_NAME():
https://developer.a
ahatanak added a comment.
ping
https://reviews.llvm.org/D36918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet added a comment.
Nice catch, it looks good to me! Thank you!
One small nit for future debugging people: Could you insert a comment line in
the test case where you explain what is this all about? E.g what you just have
written in the description: "invalidateRegions() will construct the
Sy
smeenai created this revision.
smeenai added reviewers: ahatanak, compnerd, majnemer, rjmccall, rnk.
The inline assembly generated for the ARC autorelease elision marker
must have a funclet token if it's emitted inside a funclet, otherwise
the inline assembly (and all subsequent code in the funcle
Author: hokein
Date: Mon Mar 19 12:13:03 2018
New Revision: 327887
URL: http://llvm.org/viewvc/llvm-project?rev=327887&view=rev
Log:
[clang-move] Fix the failing test caused by changes in clang-format.
Modified:
clang-tools-extra/trunk/test/clang-move/move-used-helper-decls.cpp
Modified: cla
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
We should really just switch the reclaim to be marked with a bundle in the
first place, but that's not a reasonable thing to ask you to do.
Repository:
rC Clang
https://reviews.
mibintc added a comment.
I added some inline comments. You are using the Intel 18.0 compiler on Windows
- what version of Visual Studio is in the environment?
Comment at: include/llvm-c/Target.h:25
-#if defined(_MSC_VER) && !defined(inline)
+#if defined(_MSC_VER) && !defined
Author: smeenai
Date: Mon Mar 19 12:34:39 2018
New Revision: 327892
URL: http://llvm.org/viewvc/llvm-project?rev=327892&view=rev
Log:
[CodeGen] Add funclet token to ARC marker
The inline assembly generated for the ARC autorelease elision marker
must have a funclet token if it's emitted inside a f
marsupial updated this revision to Diff 138982.
https://reviews.llvm.org/D44643
Files:
include/clang/Lex/HeaderSearchOptions.h
Index: include/clang/Lex/HeaderSearchOptions.h
===
--- include/clang/Lex/HeaderSearchOptions.h
+++ inc
marsupial created this revision.
marsupial added reviewers: eugene, boris.
marsupial added a project: clang.
marsupial updated this revision to Diff 138982.
Arguments passed to HeaderSearchOptions methods are stored as std::strings,
having them converted to a StringRef at the call site can result
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327892: [CodeGen] Add funclet token to ARC marker (authored
by smeenai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44640?vs=138973&id=138983#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327892: [CodeGen] Add funclet token to ARC marker (authored
by smeenai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44640?vs=138973&id=138
thakis accepted this revision.
thakis added a comment.
Awesome, thanks! One nit below:
Comment at: include/clang/Basic/DiagnosticParseKinds.td:973
+def warn_pragma_optimize : Warning<
+ "'#pragma optimize' is not supported; use '#pragma clang optimize on|off'
instead">,
+ In
vsapsai added a comment.
I think we have agreement on this change. If there are no objections, I plan to
commit it on Wednesday, March 21.
https://reviews.llvm.org/D43494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
mgorny created this revision.
mgorny added a reviewer: eugenis.
Herald added subscribers: dberris, srhines.
mgorny added inline comments.
Comment at: test/Driver/sanitizer-ld.c:517
// CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}"
// CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclan
mgorny added inline comments.
Comment at: test/Driver/sanitizer-ld.c:517
// CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}"
// CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclang_rt.
(an alternative would be to replace this 'NOT' clause with more specific
library n
DHowett-MSFT created this revision.
DHowett-MSFT added reviewers: rnk, majnemer.
DHowett-MSFT added a project: clang.
Herald added subscribers: cfe-commits, eraman.
The MSVC compiler rejects `__forceinline` on variadic functions with the
following warning (at /https://reviews.llvm.org/W4):
C47
DHowett-MSFT added a comment.
Apologies if I've chosen the wrong set of reviewers.
Repository:
rC Clang
https://reviews.llvm.org/D44646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Hello Alexander,
This commit broke at least two of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/26909
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
. . .
Failing Tests (1):
Clang Tools :: clang-tidy/bug
smeenai added a reviewer: compnerd.
smeenai added a comment.
@DHowett-MSFT the reviewers look fine to me. Reid is the code owner for clang's
MSVC compat support. David doesn't work on this stuff directly anymore, I
think, but he's still pretty active in code reviews for it. I'm adding Saleem,
w
tra added inline comments.
Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178
+
+// In CUDA incremental processing, a CUDA ctor or dtor will be generated for
+// every statement if a fatbinary file exists.
SimeonEhrig wrote:
> tra wrote:
> > Sim
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Alright, LGTM.
https://reviews.llvm.org/D39562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
DHowett-MSFT updated this revision to Diff 138995.
DHowett-MSFT added a comment.
Fixed formatting.
Repository:
rC Clang
https://reviews.llvm.org/D44646
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/ms-forceinline-on-variadic.cpp
Index: test/Sem
DHowett-MSFT updated this revision to Diff 138996.
DHowett-MSFT added a comment.
Ran `clang-format` over changed lines. Reuploaded diff with full context.
Repository:
rC Clang
https://reviews.llvm.org/D44580
Files:
lib/Sema/SemaExpr.cpp
test/SemaObjC/block-compare.mm
Index: test/SemaOb
Author: jkorous
Date: Mon Mar 19 13:26:15 2018
New Revision: 327901
URL: http://llvm.org/viewvc/llvm-project?rev=327901&view=rev
Log:
[clangd][nfc] Give name to a magic constant
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
Modified: clang-tools-extra/trunk/clangd/index/Index.h
URL:
Author: jkorous
Date: Mon Mar 19 13:26:18 2018
New Revision: 327902
URL: http://llvm.org/viewvc/llvm-project?rev=327902&view=rev
Log:
[clangd] Fix undefined behavior due to misaligned type cast
The current code was casting pointer to a misaligned type which is undefined
behavior.
Found by compil
Author: maskray
Date: Mon Mar 19 12:05:53 2018
New Revision: 327885
URL: http://llvm.org/viewvc/llvm-project?rev=327885&view=rev
Log:
[clang-move] Fix move-used-helper-decls.cpp test.
Modified:
clang-tools-extra/trunk/test/clang-move/move-used-helper-decls.cpp
Modified: clang-tools-extra/tru
1 - 100 of 166 matches
Mail list logo
