smeenai added a reviewer: compnerd. smeenai added a comment. @DHowett-MSFT the reviewers look fine to me. Reid is the code owner for clang's MSVC compat support. David doesn't work on this stuff directly anymore, I think, but he's still pretty active in code reviews for it. I'm adding Saleem, who's also pretty active on Windows stuff.
================ Comment at: lib/Sema/SemaDeclAttr.cpp:3890 + if (Context.getTargetInfo().getCXXABI().isMicrosoft() + && hasFunctionProto(D) && isFunctionOrMethodVariadic(D)) { + Diag(Range.getBegin(), diag::warn_always_inline_on_variadic) << Ident; ---------------- The formatting here looks off (it doesn't look clang-formatted). Repository: rC Clang https://reviews.llvm.org/D44646 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits