[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

klimek added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } Optional: I'd probably let the nodeToCommandLine h

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

arphaman accepted this revision. arphaman added a reviewer: arphaman. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks https://reviews.llvm.org/D21099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D26849: [Sema] Set range end of constructors and destructors in template instantiations

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I think it LG, thanks for adding the test https://reviews.llvm.org/D26849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov added a comment. ping https://reviews.llvm.org/D25475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26849: [Sema] Set range end of constructors and destructors in template instantiations

This revision was automatically updated to reflect the committed changes. Closed by commit rL288025: [Sema] Set range end of constructors and destructors in template instantiations (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26849?vs=78522&id=79385#toc Rep

r288025 - [Sema] Set range end of constructors and destructors in template instantiations

Author: malcolm.parsons Date: Mon Nov 28 05:11:34 2016 New Revision: 288025 URL: http://llvm.org/viewvc/llvm-project?rev=288025&view=rev Log: [Sema] Set range end of constructors and destructors in template instantiations Summary: clang-tidy checks frequently use source ranges of functions. The s

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

joerg added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } klimek wrote: > Optional: I'd probably let the node

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

klimek added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } joerg wrote: > klimek wrote: > > Optional: I'd pro

Re: [PATCH] Warning for main returning a bool.

Thanks Richard for looking at the revised patch. On Mon, Nov 21, 2016 at 1:50 PM Richard Smith wrote: > This looks good to me. (While we could generalize this further, this patch > is a strict improvement, and we'll probably want to treat the 'main' case > specially regardless of whether we add

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

NoQ added a comment. This looks good to me (bikeshedded a bit), but i think Devin should have another look, because his comments were way deeper than mine. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:217 + + llvm::ImmutableList consCXXBase

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

arphaman created this revision. arphaman added reviewers: rjmccall, rsmith, mehdi_amini. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a new clang flag called `-f[no-]strict-return`. The purpose of this flag is to control how t

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

arphaman updated this revision to Diff 79396. arphaman added a comment. Fixed comment typo. Repository: rL LLVM https://reviews.llvm.org/D27163 Files: include/clang/AST/Decl.h include/clang/Basic/LangOptions.def include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.de

[clang-tools-extra] r288034 - ClangMoveTests.cpp: Fix a bogus comparison of iterator.

Author: chapuni Date: Mon Nov 28 08:27:37 2016 New Revision: 288034 URL: http://llvm.org/viewvc/llvm-project?rev=288034&view=rev Log: ClangMoveTests.cpp: Fix a bogus comparison of iterator. msc Debug build detected it. Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

yaxunl added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:954 + if (!getLangOpts().OpenCL || Ty.getAddressSpace() == LangAS::opencl_constant) +if (CGM.getCodeGenOpts().MergeAllConstants && !NRVO && !isByRef && +CGM.isTypeConstant(Ty, true)) {

[PATCH] D27049: [OpenCL] Refactor out ReadPipe/WritePipe

joey updated this revision to Diff 79399. joey added a comment. Pipe types cannot be merged by ASTContext::mergeTypes. Repository: rL LLVM https://reviews.llvm.org/D27049 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Serialization/ASTBitCodes.h lib/AST/

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please, address the small nitpick before committing. Comment at: lib/Sema/SemaDecl.cpp:5965 + +// OpenCL 1.2 spec, p6.9 r: +// The event type cann

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

mgorny added a comment. Second ping. @hfinkel, could you suggest me how to proceed with this? https://reviews.llvm.org/D25686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

mgorny added a comment. Ping. https://reviews.llvm.org/D26887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

joerg added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } klimek wrote: > joerg wrote: > > klimek wrote: > >

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

mgorny added a comment. Ping. https://reviews.llvm.org/D26764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

mgorny added a comment. Ping. https://reviews.llvm.org/D26796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

klimek added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } joerg wrote: > klimek wrote: > > joerg wrote: > >

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

Anastasia updated this revision to Diff 79403. Anastasia added a comment. Merged if statements into one! https://reviews.llvm.org/D27109 Files: lib/CodeGen/CGDecl.cpp test/CodeGenOpenCL/constant-addr-space-globals.cl Index: test/CodeGenOpenCL/constant-addr-space-globals.cl ===

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

joerg added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } klimek wrote: > joerg wrote: > > klimek wrote: > >

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

arphaman created this revision. arphaman added reviewers: aaron.ballman, manmanren. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a new ``format_dynamic_key_arg``. It's intended to be used instead of ``format_arg`` for methods/

r288039 - [OPENMP] Fix for PR31137: Wrong DSA for members in struct.

Author: abataev Date: Mon Nov 28 09:55:15 2016 New Revision: 288039 URL: http://llvm.org/viewvc/llvm-project?rev=288039&view=rev Log: [OPENMP] Fix for PR31137: Wrong DSA for members in struct. If member expression is used in the task region and the base expression is a DeclRefExp and the variable

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 79406. yaxunl added a comment. Revised by John's comments. Emit null pointer in target-specific representation in folded constant expressions. Fix casting null pointer to integer in constant expressions. https:/

[PATCH] D26672: Avoid -Wshadow warnings for parameters that shadow fields in setter-like methods

arphaman added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D26672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D27109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, Prazek, alexfh. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: JDevlieghere. Use auto when declaring variables that are initialized by calling a templated function that returns its e

[PATCH] D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl

a.sidorin added a comment. Hello Kareem. There are some tests in "class-template" dir that may serve as example. You don't need a warning for a function that was found: you should just return found declaration. There is already a warning for a declaration that is defined in multiple TUs. You c

[PATCH] D27167: [libc++] Support multibyte decimal_point and thousands_sep

vangyzen created this revision. vangyzen added a subscriber: cfe-commits. Herald added a subscriber: emaste. Herald added a reviewer: EricWF. numpunct_byname assumed that decimal_point and thousands_sep were ASCII and simply copied the first byte from them. Add support for multibyte strings in th

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

beanz added a reviewer: eugenis. beanz added a subscriber: eugenis. beanz added a comment. Looping in @eugenis, who added i686 support in r218761. eugenis, since i686 is identical to i386 generating it as a separate target is undesirable. Can you help advise as to how we can better meet your nee

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added inline comments. Comment at: projects/libcxx/test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:79 const std::numpunct& np = std::use_facet >(l); -assert(np.thousands_sep() == L','); +

[clang-tools-extra] r288043 - [include-fixer] Don't interfere with typo correction if we found nothing.

Author: d0k Date: Mon Nov 28 11:16:18 2016 New Revision: 288043 URL: http://llvm.org/viewvc/llvm-project?rev=288043&view=rev Log: [include-fixer] Don't interfere with typo correction if we found nothing. Just let the existing typo correction machinery handle that. Modified: clang-tools-extra

[PATCH] D26335: [ms] Reinstate https://reviews.llvm.org/D14748 after https://reviews.llvm.org/D20291

hans added inline comments. Comment at: lib/Headers/x86intrin.h:49 +static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__)) +__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; } +#ifdef __x86_64__ andreadb wrote: > hans w

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

mehdi_amini added a comment. What is the justification for a platform specific default change here? Repository: rL LLVM https://reviews.llvm.org/D27163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: Upgrade and fix clang-format-vs

On Fri, Nov 25, 2016 at 6:58 PM, Antonio Maiorano wrote: > Ah, no, that's not what I meant. The required referenced assemblies are > versions that are normally installed with VS 2010. > > The first time I worked on this, I had upgraded the referenced assemblies to > the ones that ship with VS 2015

[PATCH] D26991: Hoist redundant load

sebpop added a comment. Let's also add a testcase and show the performance improvement. https://reviews.llvm.org/D26991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

mgorny added a comment. In https://reviews.llvm.org/D26764#606638, @beanz wrote: > Looping in @eugenis, who added i686 support in r218761. > > eugenis, since i686 is identical to i386 generating it as a separate target > is undesirable. Can you help advise as to how we can better meet your needs

[PATCH] D27068: Improve string::find

sebpop added a comment. Please also post the performance numbers from the added benchmarks with and without the change to the lib. Comment at: libcxx/benchmarks/string.bench.cpp:12 +// until the end of s1. +static void BM_StringFindPhase1(benchmark::State& state) { + // Bench

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

arphaman added a comment. In https://reviews.llvm.org/D27163#606695, @mehdi_amini wrote: > What is the justification for a platform specific default change here? The flag itself is platform agnostic, however, the default value is different on Darwin (-fno-strict-return). The reason for this di

[PATCH] D27140: Allow clang to write compilation database records

joerg removed rL LLVM as the repository for this revision. joerg updated this revision to Diff 79423. joerg added a comment. Use llvm::yaml::escape. https://reviews.llvm.org/D27140 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp Index: include/clang/Driver/Options.td ==

[PATCH] D26137: [clang-tidy] Add check name to YAML export

alexfh added a comment. I'll try to get back to this code review soon. Sorry for the delay. Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D27068: Improve string::find

mclow.lists added a comment. Definitely want to see numbers. https://reviews.llvm.org/D27068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

eugenis added a comment. I think this is the right move together with https://reviews.llvm.org/D26796. Android build system will need to support both names for some time, depending on the toolchain version - looks doable. Technically, it can stick with the old name forever. https://reviews.llv

[PATCH] D26991: Hoist redundant load

mclow.lists added a comment. /me wonders what the perf difference when `_LIBCPP_UNROLL_LOOPS` is defined or not. I think this (`_LIBCPP_UNROLL_LOOPS`) falls squarely into Chandler's request that we complain to him when the compiler generates sub-optimal code, instead of doing things like manu

[PATCH] D26991: Hoist redundant load

mclow.lists added a comment. __search is the only place where `_LIBCPP_UNROLL_LOOPS` is currently used. https://reviews.llvm.org/D26991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D26896: [libcxx] Make constexpr char_traits and char_traits

mclow.lists added inline comments. Comment at: include/__string:213 -static inline int compare(const char_type* __s1, const char_type* __s2, size_t __n) _NOEXCEPT -{return __n == 0 ? 0 : memcmp(__s1, __s2, __n);} -static inline size_t length(const char_type* __

[PATCH] D27096: Protect locale tests under noexceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This LGTM. https://reviews.llvm.org/D27096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

Eugene.Zelenko added a comment. It'll be worth to mention enhancement in Release Notes. https://reviews.llvm.org/D27166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Upgrade and fix clang-format-vs

On Mon, Nov 28, 2016 at 10:46 AM, Antonio Maiorano wrote: > Okay, I'll see if upgrading to the 2015 assemblies would allow the VSIX to > keep working in older versions of VS. > > Still waiting on an answer to this question: > >> In either case, though, I must ask: how is the offical vsix that's >>

[PATCH] D27093: Protect std::{, unordered_}map tests under noexceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D27093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D27095: Protect std::array tests under noexceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Other than the missing `assert`s, (which are not your fault, but I would appreciate you fixing) this LGTM. Comment at: test/std/containers/sequences/array/at.pass.

[PATCH] D26611: Protect test for dynarray under libcpp-no-exceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D26611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D26612: Protect std::string tests under libcpp-no-exceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D26612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D27167: [libc++] Support multibyte decimal_point and thousands_sep

vangyzen added a comment. A unit test change in https://reviews.llvm.org/D26979 found this and will continue to test it (on some OSes). https://reviews.llvm.org/D27167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: Upgrade and fix clang-format-vs

On Mon, Nov 28, 2016 at 11:11 AM, Antonio Maiorano wrote: >> It's built with the script in utils/release/build_llvm_package.bat > which I run manually on my machine once every few weeks. > > Okay, that's good news. So the simplest path to success would be to require > the user to either pass the p

[PATCH] D26991: Hoist redundant load

sebpop added a comment. In https://reviews.llvm.org/D26991#606764, @mclow.lists wrote: > /me wonders what the perf difference when `_LIBCPP_UNROLL_LOOPS` is defined > or not. > > I think this (`_LIBCPP_UNROLL_LOOPS`) falls squarely into Chandler's request > that we complain to him when the com

[PATCH] D27068: Improve string::find

sebpop added a comment. In https://reviews.llvm.org/D27068#606757, @mclow.lists wrote: > Definitely want to see numbers. master: Benchmark Time CPU Iterations --- BM_StringFindPhase1/10

[PATCH] D27068: Improve string::find

sebpop added a comment. The numbers are from an x86_64-linux machine: Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz Overall the patch is a win on the synthetic benchmark. We have also seen this in a proprietary benchmark where it accounted for about 10% speedup. https://reviews.llvm.org/D27068 _

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

mehdi_amini added a comment. In https://reviews.llvm.org/D27163#606744, @arphaman wrote: > In https://reviews.llvm.org/D27163#606695, @mehdi_amini wrote: > > > What is the justification for a platform specific default change here? > > > The flag itself is platform agnostic, however, the default v

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

sebpop added a comment. @mclow.lists could you please have a last look at this patch: the change is for a performance improvement (20% uplift on a proprietary benchmark), and all the issues mentioned in the review have been addressed. The existing synthetic benchmark shows an overall improvement

[PATCH] D26955: Fix bitwidth for x87 extended-precision floating-point type

bruno added inline comments. Comment at: lib/Basic/TargetInfo.cpp:229 switch (BitWidth) { - case 96: + case 80: if (&getLongDoubleFormat() == &llvm::APFloat::x87DoubleExtended) The change makes sense but I believe there's some historical reason why this

[PATCH] D27157: IRGen: Remove all uses of CreateDefaultAlignedLoad.

pcc updated this revision to Diff 79436. pcc marked an inline comment as done. pcc added a comment. - Address review comments https://reviews.llvm.org/D27157 Files: clang/lib/CodeGen/CGBuilder.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGObjCGNU.cpp

[PATCH] D27157: IRGen: Remove all uses of CreateDefaultAlignedLoad.

pcc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2195 LoadInst *Load = -Builder.CreateDefaultAlignedLoad(IntToPtr, /*isVolatile=*/true); +Builder.CreateAlignedLoad(IntTy, IntToPtr, CharUnits::fromQuantity(4)); +Load->setVolatile(true

r288059 - [MS] Mangle a unique ID into all MS inline asm labels

Author: rnk Date: Mon Nov 28 14:52:19 2016 New Revision: 288059 URL: http://llvm.org/viewvc/llvm-project?rev=288059&view=rev Log: [MS] Mangle a unique ID into all MS inline asm labels This solves PR23715 in a way that is compatible with LTO. MSVC supports jumping to source-level labels and betwe

[PATCH] D26916: [ObjC] Avoid a @try/@finally/@autoreleasepool fixit when parsing an expression

bruno added a comment. Hi Alex, thanks for working on this Comment at: lib/Parse/ParseObjc.cpp:2877 +if (GetLookAheadToken(1).is(tok::l_brace) && +ExprStatementTokLoc == AtLoc) { char ch = Tok.getIdentifierInfo()->getNameStart()[0]; --

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

Quuxplusone added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:530 + // Don't need to mark Objective-C methods or blocks since the undefined + // behaviour optimization isn't used for them. +} This seems like a trap waiting to spring on someo

r288060 - [Driver] Refactor distro detection & classification as a separate API

Author: mgorny Date: Mon Nov 28 15:11:14 2016 New Revision: 288060 URL: http://llvm.org/viewvc/llvm-project?rev=288060&view=rev Log: [Driver] Refactor distro detection & classification as a separate API Refactor the Distro enum along with helper functions into a full-fledged Distro class, inspire

r288061 - [Driver] Fix recognizing newer OpenSUSE versions

Author: mgorny Date: Mon Nov 28 15:11:18 2016 New Revision: 288061 URL: http://llvm.org/viewvc/llvm-project?rev=288061&view=rev Log: [Driver] Fix recognizing newer OpenSUSE versions Fix recognizing newer OpenSUSE versions that combine the two version components into 'VERSION = x.y'. The check was

r288062 - [Driver] Add unit tests for Distro detection

Author: mgorny Date: Mon Nov 28 15:11:22 2016 New Revision: 288062 URL: http://llvm.org/viewvc/llvm-project?rev=288062&view=rev Log: [Driver] Add unit tests for Distro detection Add a set of unit tests for the distro detection code. The tests use an in-memory virtual filesystems resembling releas

[PATCH] D25949: [Driver] Refactor distro detection & classification as a separate API

This revision was automatically updated to reflect the committed changes. Closed by commit rL288060: [Driver] Refactor distro detection & classification as a separate API (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25949?vs=78462&id=79442#toc Repository: rL LLVM

[PATCH] D25869: [Driver] Add unit tests for Distro detection

This revision was automatically updated to reflect the committed changes. Closed by commit rL288062: [Driver] Add unit tests for Distro detection (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25869?vs=78625&id=79444#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D25928: [cfi] Enable cfi-icall on ARM and AArch64.

eugenis closed this revision. eugenis added a comment. Committed in r286613 Repository: rL LLVM https://reviews.llvm.org/D25928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27157: IRGen: Remove all uses of CreateDefaultAlignedLoad.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:126 // FIXME: these "default-aligned" APIs should be removed, // but I don't feel like fixing all the builtin code right now. llvm::StoreInst *CreateDefaultAlignedStore(llvm::Value *Val, --

[PATCH] D27157: IRGen: Remove all uses of CreateDefaultAlignedLoad.

pcc added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:126 // FIXME: these "default-aligned" APIs should be removed, // but I don't feel like fixing all the builtin code right now. llvm::StoreInst *CreateDefaultAlignedStore(llvm::Value *Val, ---

[PATCH] D26991: Hoist redundant load

mclow.lists added a comment. There are no uses of `_LIBCPP_UNROLL_LOOPS` in LLVM (other than the ones in ``. Googling for `_LIBCPP_UNROLL_LOOPS` on github finds the ones in libc++, and no others. I think I'll just take it out, and see what happens. https://reviews.llvm.org/D26991 _

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

mehdi_amini added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:530 + // Don't need to mark Objective-C methods or blocks since the undefined + // behaviour optimization isn't used for them. +} Quuxplusone wrote: > This seems like a trap waiti

[PATCH] D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl

spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. There are several missing imports here, as well as a few minor nits. If the unit test cases aren't catching these, I'm a little concerned. We should be catching this. Also we should

[PATCH] D26955: Fix bitwidth for x87 extended-precision floating-point type

ddcc added inline comments. Comment at: lib/Basic/TargetInfo.cpp:229 switch (BitWidth) { - case 96: + case 80: if (&getLongDoubleFormat() == &llvm::APFloat::x87DoubleExtended) bruno wrote: > The change makes sense but I believe there's some historical r

[PATCH] D26800: [Sema] Make __attribute__((notnull)) inheritable through function parameters

bettinson added a comment. ping https://reviews.llvm.org/D26800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes

spyffe added a comment. I only have a stylistic nit to add to Aleksei's comments. Comment at: lib/AST/ASTImporter.cpp:6492 + UnresolvedSet<8> ToDecls; + for (UnresolvedLookupExpr::decls_iterator S = E->decls_begin(), +F = E->decls_e

[PATCH] D26955: Fix bitwidth for x87 extended-precision floating-point type

efriedma added inline comments. Comment at: lib/Basic/TargetInfo.cpp:229 switch (BitWidth) { - case 96: + case 80: if (&getLongDoubleFormat() == &llvm::APFloat::x87DoubleExtended) ddcc wrote: > bruno wrote: > > The change makes sense but I believe there

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

rjmccall added inline comments. Comment at: test/CodeGenCXX/return.cpp:21 + // CHECK-NOSTRICT-NEXT: load + // CHECK-NOSTRICT-NEXT: ret i32 + // CHECK-NOSTRICT-NEXT: } mehdi_amini wrote: > Quuxplusone wrote: > > Can you explain why a load from an uninitialized

[PATCH] D26753: ASTImporter: improve support for C++ templates

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. Yeah, that test looks great! Thanks! Comment at: lib/AST/ASTImporter.cpp:496 +return false; + if (DN1->isIdentifier()) +return IsStructurallyEquivalent(

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

mehdi_amini added inline comments. Comment at: test/CodeGenCXX/return.cpp:21 + // CHECK-NOSTRICT-NEXT: load + // CHECK-NOSTRICT-NEXT: ret i32 + // CHECK-NOSTRICT-NEXT: } rjmccall wrote: > mehdi_amini wrote: > > Quuxplusone wrote: > > > Can you explain why a lo

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

rsmith added a comment. A target-specific default for this, simply because there's a lot of code on Darwin that happens to violate this language rule, doesn't make sense to me. Basing the behavior on whether a `-Wreturn-type` warning would have been emitted seems like an extremely strange heuri

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

bruno added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8064 + ScalarCast = CK_FloatingCast; +} else if (ScalarTy->isIntegralType(S.Context)) { + // Determine if the integer constant can be expressed as a floating point sdardis wrote: > bruno

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

rsmith added a comment. In https://reviews.llvm.org/D27163#607078, @rsmith wrote: > A target-specific default for this, simply because there's a lot of code on > Darwin that happens to violate this language rule, doesn't make sense to me. ... but rjmccall's explanation of the problem helps. Th

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

bruno added a comment. @rsmith ping! https://reviews.llvm.org/D26267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

rjmccall added a comment. In https://reviews.llvm.org/D27163#607100, @rsmith wrote: > In https://reviews.llvm.org/D27163#607078, @rsmith wrote: > > > A target-specific default for this, simply because there's a lot of code on > > Darwin that happens to violate this language rule, doesn't make se

r288081 - Make CGVTables use ConstantInitBuilder. NFC.

Author: rjmccall Date: Mon Nov 28 16:18:33 2016 New Revision: 288081 URL: http://llvm.org/viewvc/llvm-project?rev=288081&view=rev Log: Make CGVTables use ConstantInitBuilder. NFC. Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp cfe/trunk/lib/CodeGen/CGVTables.h cfe/trunk/lib/CodeGen/It

r288080 - Hide the result of building a constant initializer. NFC.

Author: rjmccall Date: Mon Nov 28 16:18:30 2016 New Revision: 288080 URL: http://llvm.org/viewvc/llvm-project?rev=288080&view=rev Log: Hide the result of building a constant initializer. NFC. Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/

r288079 - ConstantBuilder -> ConstantInitBuilder for clarity, and

Author: rjmccall Date: Mon Nov 28 16:18:27 2016 New Revision: 288079 URL: http://llvm.org/viewvc/llvm-project?rev=288079&view=rev Log: ConstantBuilder -> ConstantInitBuilder for clarity, and move the member classes up to top level to allow forward declarations to name them. NFC. Modified: cf

[PATCH] D27157: IRGen: Remove all uses of CreateDefaultAlignedLoad.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:126 // FIXME: these "default-aligned" APIs should be removed, // but I don't feel like fixing all the builtin code right now. llvm::StoreInst *CreateDefaultAlignedStore(llvm::Value *Val, --

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

rsmith added inline comments. Comment at: lib/Frontend/FrontendActions.cpp:227 +IsBuiltin = true; + addHeaderInclude(H.NameAsWritten, Includes, LangOpts, Module->IsExternC, + IsBuiltin /*AlwaysInclude*/); I don't understand why

r288083 - IRGen: Remove all uses of CreateDefaultAlignedLoad.

Author: pcc Date: Mon Nov 28 16:30:21 2016 New Revision: 288083 URL: http://llvm.org/viewvc/llvm-project?rev=288083&view=rev Log: IRGen: Remove all uses of CreateDefaultAlignedLoad. Differential Revision: https://reviews.llvm.org/D27157 Modified: cfe/trunk/lib/CodeGen/CGBuilder.h cfe/tru

[PATCH] D27157: IRGen: Remove all uses of CreateDefaultAlignedLoad.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288083: IRGen: Remove all uses of CreateDefaultAlignedLoad. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D27157?vs=79436&id=79462#toc Repository: rL LLVM https://reviews.llvm

  1   2   >