klimek added inline comments.

================
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+        nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+        Output ? Output->getValue(OutputStorage) : "");
   }
----------------
Optional: I'd probably let the nodeToCommandLine handle the null value and make 
this code more straight forward?


Repository:
  rL LLVM

https://reviews.llvm.org/D27138



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to