vmiklos added a comment.
Hi,
> Also: should we add a check that the token of the source location we find
> actually has the old name?
Hmm, how do I get the token at a specific SourceLocation? The best I found so
far is SourceManager::getBuffer(), but that looks more like looking up raw
bytes
On Thu, May 12, 2016 at 9:22 AM Miklos Vajna wrote:
> vmiklos added a comment.
>
> Hi,
>
> > Also: should we add a check that the token of the source location we
> find actually has the old name?
>
>
> Hmm, how do I get the token at a specific SourceLocation? The best I found
> so far is SourceMa
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:38
@@ -37,1 +37,3 @@
+// Ignores using-declarations defined in macro.
+if (Result.SourceManager->
djasper added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:39
@@ +38,3 @@
+// Ignores using-declarations defined in macro.
+if (Result.SourceManager->isMacroBodyExpansion(TargetDecl->getLocStart()),
+Result.SourceManager->isMacroBodyExpans
avt77 marked 2 inline comments as done.
Comment at: lib/Sema/SemaDeclCXX.cpp:4813
@@ +4812,3 @@
+// and move constructor, so don't attempt to import/export them if
+// we have a definition.
+auto *CXXC = dyn_cast(MD);
rnk wrote:
> Oh, so we
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/SemaOpenCL/to_addr_builtin.cl:26
@@ +25,3 @@
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0
+ // expected-error@-2{{'to_global' needs OpenCL version 2.0 o
krystyna updated this revision to Diff 57007.
krystyna marked 8 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D18919
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseUsingCheck.cpp
clang-tidy/moderniz
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseUsingCheck.cpp:13
@@ +12,3 @@
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include
+
Is this required?
Repository:
rL LLVM
http://reviews.llvm.org/D18919
___
hokein updated this revision to Diff 57008.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20197
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
hokein marked 3 inline comments as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:39
@@ +38,3 @@
+// Ignores using-declarations defined in macros.
+if (TargetDecl->getLocation().isMacroID())
+ return;
Good point. Using `isMacroID` is enou
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This change automatically sorts ES6 imports and exports into four groups:
absolute imports, parent imports, relative imports, and then exports. Exports
are
Author: hokein
Date: Thu May 12 05:00:49 2016
New Revision: 269278
URL: http://llvm.org/viewvc/llvm-project?rev=269278&view=rev
Log:
[clang-tidy] Ignore using-declarations defined in marcro in
misc-unused-using-decls checks.
Reviewers: djasper
Subscribers: cfe-commits
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL269278: [clang-tidy] Ignore using-declarations defined in
marcro in misc-unused-using… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20
djasper added a comment.
Just two high-level comments. Will review in more depth later.
Comment at: include/clang/Format/Format.h:770
@@ +769,3 @@
+/// ``export`` blocks are affected by ``Ranges``.
+tooling::Replacements sortJavaScriptIncludes(const FormatStyle &Style,
+
Author: koriakin
Date: Thu May 12 05:27:59 2016
New Revision: 269279
URL: http://llvm.org/viewvc/llvm-project?rev=269279&view=rev
Log:
[Driver] Squash misleading indentation warning.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/viewv
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D20200
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
aturetsk updated this revision to Diff 57017.
aturetsk added a comment.
Fix the remarks.
http://reviews.llvm.org/D19274
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/ToolChain.h
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.cpp
lib/D
Author: mprobst
Date: Thu May 12 06:20:32 2016
New Revision: 269282
URL: http://llvm.org/viewvc/llvm-project?rev=269282&view=rev
Log:
clang-format: [JS] respect clang-format off when requoting strings.
Reviewers: djasper
Subscribers: klimek, cfe-commits
Differential Revision: http://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269282: clang-format: [JS] respect clang-format off when
requoting strings. (authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D20200?vs=57014&id=57018#toc
Repository:
rL LLVM
h
aturetsk added a comment.
Hi Bruno,
Thanks for the review.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:157
@@ -156,1 +156,3 @@
+def err_drv_cxx_not_supported : Error<
+ "C++ is not supported for target '%0'">;
Yes. I've found nothing similar.
==
jbcoe updated this revision to Diff 57022.
jbcoe marked 6 inline comments as done.
jbcoe added a comment.
Apply fixes from review.
http://reviews.llvm.org/D16962
Files:
clang-tidy/modernize/AvoidBindCheck.cpp
clang-tidy/modernize/AvoidBindCheck.h
clang-tidy/modernize/CMakeLists.txt
clan
rivanvx updated this revision to Diff 57023.
rivanvx added a comment.
Now with 100% more tests.
http://reviews.llvm.org/D20168
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
Index: test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
a.makarov added inline comments.
Comment at: lib/AST/ASTContext.cpp:8604-8606
@@ -8603,5 +8603,5 @@
bool IsCXXMethod) const {
// Pass through to the C++ ABI object
if (IsCXXMethod)
return ABI->getDefaultMethodCallConv
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
Do you need someone to submit the patch for you?
Comment at: clang-tidy/modernize/AvoidBindCheck.cpp:28
@@ +27,3 @@
+ BindArgumentKind Kind = BK_Other
jbcoe added a comment.
I can submit the patch myself, thanks.
Thanks again for taking the time to give such a thorough review.
http://reviews.llvm.org/D16962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
alexfh added inline comments.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:139
@@ +138,3 @@
+ const LangOptions &LO = Finder->getASTContext().getLangOpts();
+ SourceLocation Loc = Node.getExprLoc();
+ while (Loc.isMacroID()) {
Ah, found it: `llvm/AD
flx added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:32
@@ +31,3 @@
+ auto *Record = Type->getAsCXXRecordDecl();
+ if (Record == nullptr || !Record->hasDefinition())
+return false;
aaron.ballman wrote:
> `!Record` instead of explicit compar
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 57035.
flx marked 5 inline comments as done.
http://reviews.llvm.org/D20170
Files:
clang-tidy/utils/TypeTraits.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/perform
mprobst updated this revision to Diff 57037.
mprobst added a comment.
- extract TokenAnalyzer.h and SortJavaScriptImports.h/cpp
- clean up imports
http://reviews.llvm.org/D20198
Files:
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.h
mprobst marked 2 inline comments as done.
mprobst added a comment.
http://reviews.llvm.org/D20198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cameron314 added a comment.
You're right, this breaks that test. The corner case that it exercises is
arguably less important than breaking all spelling ranges, though. But I'm
going to see if I can fix both with a little wizardry (ideally there wouldn't
be open ranges in the first place, since
aaron.ballman added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:31
@@ +30,3 @@
+
+bool hasDeletedCopyConstructor(QualType Type, ASTContext &Context) {
+ auto *Record = Type->getAsCXXRecordDecl();
No need to pass in `Context` any longer.
mclow.lists added a subscriber: mclow.lists.
mclow.lists accepted this revision.
mclow.lists added a reviewer: mclow.lists.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
`C` and `D` are different failure modes for `uses_allocator`, since the
standard says th
mprobst updated this revision to Diff 57039.
mprobst added a comment.
- extract TokenAnalyzer.h and SortJavaScriptImports.h/cpp
- clean up imports/
- includes
http://reviews.llvm.org/D20198
Files:
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/Format
a.makarov added inline comments.
Comment at: lib/AST/ASTContext.cpp:8616-8619
@@ +8615,6 @@
+ return CC_C;
+case LangOptions::DCC_FastCall:
+ return CC_X86FastCall;
+case LangOptions::DCC_StdCall:
+ return CC_X86StdCall;
+case LangOptions::DCC_VectorCall
Author: marshall
Date: Thu May 12 09:31:35 2016
New Revision: 269298
URL: http://llvm.org/viewvc/llvm-project?rev=269298&view=rev
Log:
Apply D20014 - fix a missing return in a test. Fixes PR#27720
Modified:
libcxx/trunk/test/std/utilities/memory/allocator.uses/allocator.uses.trait/uses_alloc
Prazek added a reviewer: Prazek.
Comment at: clang-tidy/misc/UnnecessaryMutableCheck.cpp:152
@@ +151,3 @@
+// it is the only declaration in a declaration chain.
+static bool CheckRemoval(SourceManager &SM, const SourceLocation &LocStart,
+ const SourceLocat
etienneb created this revision.
etienneb added reviewers: klimek, aaron.ballman.
etienneb added subscribers: cfe-commits, alexfh, sbenza.
This patch moves the enum definitions to a definition (.def) file.
These modifications provide way to list enumerator of a given type.
As an example, this all
rmaprath added a comment.
Gentle ping.
http://reviews.llvm.org/D20119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/modernize/UseUsingCheck.cpp:13
@@ +12,3 @@
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include
+
Prazek wrote:
> Is this required?
It'll be reasonable to run Include What You Use at least on new fi
alexfh added a comment.
Manuel, ping.
http://reviews.llvm.org/D17981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb updated this revision to Diff 57043.
etienneb added a comment.
Herald added a subscriber: klimek.
rebase over AST modifications
http://reviews.llvm.org/D20207
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
Hi,
I have fixed the things you mentioned now. I have attached the new patch to
this email.
Best regards,
Mads Ravn
On Wed, May 11, 2016 at 11:54 PM Vedant Kumar wrote:
> Hi,
>
> Thanks for the patch!
>
> This patch is missing a small, lit-style test case. You can find examples
> of test cases
etienneb updated this revision to Diff 57044.
etienneb marked an inline comment as done.
etienneb added a comment.
rebase over AST modifications
http://reviews.llvm.org/D19871
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Regi
etienneb updated this revision to Diff 57045.
etienneb added a comment.
remove incorrect patch upload (sorry)
http://reviews.llvm.org/D20207
Files:
include/clang/AST/OperationKinds.def
include/clang/AST/OperationKinds.h
include/clang/module.modulemap
lib/AST/Expr.cpp
Index: lib/AST/Exp
mprobst created this revision.
mprobst added reviewers: djasper, bkramer.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Simply looking at the final text greatly simplifies the algorithm and also
fixes a reported issue. This requires duplicating the "actual encoding wi
etienneb marked 3 inline comments as done.
etienneb added a comment.
This patch has been modified to support dynamic matchers.
It rely on : http://reviews.llvm.org/D20207
Comments?
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102
@@ +101,3 @@
+ static clang::CastKind getC
bkramer requested changes to this revision.
bkramer added a comment.
This revision now requires changes to proceed.
This needs more tests (check that using stuff from a different namespace in
namespace scope still works). It's also better written as a unit test against
the in-memory database, th
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rL LLVM
http://reviews.llvm.org/D20203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
alexfh added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:22
@@ +21,3 @@
+
+using namespace ::clang::ast_matchers;
+
Now seems to be unused.
http://reviews.llvm.org/D20170
___
cfe-commits mailing lis
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Generally, I think this looks good. It will definitely help with AST matchers.
Richard, do you have any problems with this approach?
Comment at: include/clang/AST/OperationKinds.def:15
@@ +14,3 @@
+//
+/// @
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/performance-inefficient-string-addition.rst:8
@@ +7,3 @@
+--
+This ch
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Reduce space in empty constructors and between data members and first public
section.
Fix som
Author: stulova
Date: Thu May 12 11:28:25 2016
New Revision: 269305
URL: http://llvm.org/viewvc/llvm-project?rev=269305&view=rev
Log:
[OpenCL] Output OpenCL version in diagnostics.
Diagnostics should note version dependent issues by giving
a hint about current version being compiled for.
This pa
Anastasia added a comment.
Sure. Committed in r269305!
Thanks!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wristow added a comment.
Ping
http://reviews.llvm.org/D19815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:501
@@ -500,1 +500,3 @@
def err_builtin_needs_feature : Error<"%0 needs target feature %1">;
+def err_builtin_needs_opencl_version
+: Error<"%0 needs OpenCL version %1%select{| or above}2"
djasper added a comment.
I experimented a bit. What do you think of this?
Comment at: lib/Format/Format.cpp:1822
@@ +1821,3 @@
+cleanupRight(Line->First, Line->Last, tok::comma, tok::comma);
+checkConstructorInitList(*Line);
+ }
You could tu
hans added inline comments.
Comment at: utils/TableGen/ClangAttrEmitter.cpp:338
@@ -310,1 +337,3 @@
+OS << "\n\n static const " << getType() << " Default" <<
getUpperName()
+ << " = " << Default << ";";
}
Everything up to the " = " part is
etienneb marked an inline comment as done.
etienneb added a comment.
Comment at: include/clang/AST/OperationKinds.def:15
@@ +14,3 @@
+//
+/// @file OperationKinds.def
+///
aaron.ballman wrote:
> Do we use @file doxygen comments usually? I'm not certain if I've
a.makarov updated this revision to Diff 57062.
a.makarov added a comment.
Thanks for the review! I've updated the patch, please take a look.
Modifications:
- the dependency from MS compatibility mode is removed;
- the option is renamed into '-fdefault-calling-conv' (since it's not in MS
compatib
Author: filcab
Date: Thu May 12 11:51:36 2016
New Revision: 269309
URL: http://llvm.org/viewvc/llvm-project?rev=269309&view=rev
Log:
[ubsan] Add -fsanitize-undefined-strip-path-components=N
Summary:
This option allows the user to control how much of the file name is
emitted by UBSan. Tuning this
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269309: [ubsan] Add
-fsanitize-undefined-strip-path-components=N (authored by filcab).
Changed prior to commit:
http://reviews.llvm.org/D19666?vs=56396&id=57063#toc
Repository:
rL LLVM
http://review
Anastasia added a comment.
In http://reviews.llvm.org/D18369#424617, @yaxunl wrote:
> In http://reviews.llvm.org/D18369#424347, @pxli168 wrote:
>
> > In http://reviews.llvm.org/D18369#422367, @yaxunl wrote:
> >
> > > In http://reviews.llvm.org/D18369#421963, @pxli168 wrote:
> > >
> > > > If we wa
djasper added inline comments.
Comment at: lib/Format/Format.cpp:21
@@ -19,1 +20,3 @@
#include "TokenAnnotator.h"
+#include "FormatTokenLexer.h"
+#include "TokenAnalyzer.h"
Use clang-format to fix the order :-)
Comment at: lib/Format/FormatToken
Anastasia added inline comments.
Comment at: lib/Sema/SemaType.cpp:2055
@@ -2054,3 +2054,3 @@
- return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser,
- S.LangOpts.GNUMode).isInvalid();
+ return S
+ .VerifyIntege
apelete added inline comments.
Comment at: lib/AST/ASTDiagnostic.cpp:1686
@@ -1685,3 +1685,3 @@
-if (Same) {
+if (Same && FromTD) {
OS << "template " << FromTD->getNameAsString();
rtrieu wrote:
> dblaikie wrote:
> > Should this be a condition, or
majnemer added inline comments.
Comment at: include/clang/Basic/LangOptions.def:175
@@ -174,2 +174,3 @@
ENUM_LANGOPT(MSPointerToMemberRepresentationMethod,
PragmaMSPointersToMembersKind, 2, PPTMK_BestCase, "member-pointer
representation method")
+ENUM_LANGOPT(DefaultMSCallingCo
hintonda updated this revision to Diff 57065.
hintonda added a comment.
- Renamed private helper method
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/U
mprobst updated this revision to Diff 57066.
mprobst added a comment.
- simplify logic by parsing forward, reduce complexity to O(n) from O(n^2)
http://reviews.llvm.org/D20208
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
==
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:197
@@ +196,3 @@
+
+ Replaces dynamic exception specifications with noexcept.
+
Please highlight noexcept with ``.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.
jbcoe updated this revision to Diff 57067.
jbcoe added a comment.
update diff to allow arc to apply patch.
http://reviews.llvm.org/D16962
Files:
clang-tidy/modernize/AvoidBindCheck.cpp
clang-tidy/modernize/AvoidBindCheck.h
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Moderni
hintonda updated this revision to Diff 57070.
hintonda added a comment.
- Added 's around keywords in docs.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/moderni
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I've been trying to say that ABI compatibility is not the same thing as
generating the same set of exported symbols, but it really doesn't matter. If
MSVC 2013 and 2015 are not ABI compatible
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintai
rsmith added a comment.
Rather than threading through a new flag, can you test the existing `TUKind`
field?
http://reviews.llvm.org/D19815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
a.makarov updated this revision to Diff 57071.
a.makarov added a comment.
Renamed option 'DefaultMSCallingConv' into 'DefaultCallingConv' and enum
'DefaultMSCallingConvention' into 'DefaultCallingConvention'.
http://reviews.llvm.org/D20171
Files:
include/clang/Basic/LangOptions.def
include
mprobst updated this revision to Diff 57073.
mprobst marked 9 inline comments as done.
mprobst added a comment.
- extract TokenAnalyzer.h and SortJavaScriptImports.h/cpp
- clean up imports/
- includes
- address review comments
- pull out implementations from header files.
http://reviews.llvm.org
mprobst added a comment.
PTAL.
Comment at: lib/Format/SortJavaScriptImports.cpp:162
@@ +161,3 @@
+std::string ImportsText;
+for (unsigned i = 0, e = Indices.size(); i != e; ++i) {
+ JsImportExport ImpExp = Imports[Indices[i]];
djasper wrote:
> Is th
rsmith added a comment.
In http://reviews.llvm.org/D20207#428486, @aaron.ballman wrote:
> Generally, I think this looks good. It will definitely help with AST
> matchers. Richard, do you have any problems with this approach?
Not at all. This would be a nice improvement even if it didn't also p
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintaining s
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintai
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintaining s
vmiklos created this revision.
vmiklos added subscribers: cfe-commits, klimek.
This more general check could have prevented the specific problem
"getSourceOrder() == -1" guards.
http://reviews.llvm.org/D20216
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename
hintonda updated this revision to Diff 57078.
hintonda added a comment.
- Fix quote problem in docs.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseN
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:50
@@ +49,2 @@
+
+if the `ReplacementString` option is set to `NOEXCEPT`.
Actually :option: still need to prepend `ReplacementString`.
http://reviews.llvm.org/D18
hintonda updated this revision to Diff 57080.
hintonda added a comment.
- Add :option: prefix for clarity.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/moderniz
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:50
@@ +49,2 @@
+
+if the :option:`ReplacementString` option is set to `NOEXCEPT`.
I'll get it eventually... ;-)
http://reviews.llvm.org/D18575
_
Author: bruno
Date: Thu May 12 14:13:04 2016
New Revision: 269326
URL: http://llvm.org/viewvc/llvm-project?rev=269326&view=rev
Log:
[Unittests] Reverse the order of arguments for correct debug output
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/
Author: bruno
Date: Thu May 12 14:13:07 2016
New Revision: 269327
URL: http://llvm.org/viewvc/llvm-project?rev=269327&view=rev
Log:
[VFS] Reapply #2: Reconstruct the VFS overlay tree for more accurate lookup
Reapply r269100 and r269270, reverted due to
https://llvm.org/bugs/show_bug.cgi?id=27725.
etienneb added a subscriber: etienneb.
etienneb added a comment.
drive-by, some nits.
Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:31
@@ +30,3 @@
+void InefficientStringAdditionCheck::registerMatchers(MatchFinder *Finder) {
+ auto BasicStringType =
has
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/CodeGenOpenCL/as_type.cl:6
@@ +5,3 @@
+
+//CHECK: define spir_func <3 x i8> @f1(<4 x i8> %[[x:.*]])
+//CHECK: %[[astype:.*]] = shufflevector <4 x i8> %[[x
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
There virtual destructor can't be found and cause a compilation error
on a shared build.
To repro: [Release + Shared]
```
-DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON
```
Which produ
etienneb added a comment.
note: To repro, you must compile the tests.
% ninja check-all
http://reviews.llvm.org/D20218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
bader added inline comments.
Comment at: include/clang/Basic/OpenCLExtensions.def:64
@@ +63,3 @@
+OPENCLEXT_INTERNAL(cl_khr_initialize_memory, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_spir, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U)
Minimum requ
ahatanak updated this revision to Diff 57088.
ahatanak added a comment.
Add a comment explaining why it is OK to return early if the global variable
has an initializer.
http://reviews.llvm.org/D20045
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenObjCXX/arc-cxx11-init-list.mm
Index: test/CodeG
iid_iunknown created this revision.
iid_iunknown added reviewers: rengolin, t.p.northover, compnerd.
iid_iunknown added subscribers: cfe-commits, asl.
iid_iunknown set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
Clang does not detect `aapcs-vfp` for t
On Mon, May 2, 2016 at 1:17 PM, Hal Finkel wrote:
> - Original Message -
> > From: "David Blaikie"
> > To: reviews+d19708+public+e9ddc42503732...@reviews.llvm.org, "Hal
> Finkel"
> > Cc: "Richard Smith" , "Adrian Prantl" <
> apra...@apple.com>, "Duncan P. N. Exon Smith"
> > , "Eric Chri
1 - 100 of 146 matches
Mail list logo
