djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land.
Looks good. ================ Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:38 @@ -37,1 +37,3 @@ + // Ignores using-declarations defined in macro. + if (Result.SourceManager->isMacroBodyExpansion(TargetDecl->getLocStart()), ---------------- nit: "in a macro" or "in macros". ================ Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:40 @@ +39,3 @@ + if (Result.SourceManager->isMacroBodyExpansion(TargetDecl->getLocStart()), + Result.SourceManager->isMacroBodyExpansion(TargetDecl->getLocEnd())) { + return; ---------------- nit: remove braces Repository: rL LLVM http://reviews.llvm.org/D20197 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits