On 01/31/2011 10:31 PM, Gerd Lorscheid wrote:
Hi,
Hello,
the if condition in the following piece of code in game.cpp
// Modification to remove extra lines
if (CurrentPos->GetToMove() == WHITE)
tb->PrintString ("<br>");
has the following really unique format as result:
1.e4 e5 2.Nf3 Nc6
"This is the first comment" 3.Bb5 a6 4.Ba4
"This is the second comment" 4... Nf6
Is this what you intended to show (might be an e-mail markup thingy)?
My feeling is that this bit of code is responsible for adding a newline
after the comment (in either white or black case, the observer function
is confusing...). I see none here.... (?)
I think this is very hard to read and should be replaced by its
original implementation:
tb->PrintString ("<br>");
with a standard format as result.
1.e4 e5 2.Nf3 Nc6
"This is the first comment"
3.Bb5 a6 4.Ba4
"This is the second comment"
4... Nf6
The rule is easy: Moves of the main variation and only these moves
start left bound and so are easy to read and cannot be missed.
If somebody does live without newlines he may prefer
1.e4 e5 2.Nf3 Nc6 "This is the first comment" 3.Bb5 a6 4.Ba4
"This is the second comment" 4... Nf6
but this is another story.
I would like to see this little change in 4.3 if still possible.
This will be possible; certainly. We still have some time to go, I am
afraid...
One question (admittedly, before trying this myself - will do):
Did you test this in conjunction with column-style moves? CVS is down,
but this bit of code may have to do with a recent correction of spurious
blank lines in the pgn window (by Alexander)...
Besides, the code may be reused by other pgn markup stuff (to LaTeX?). I
tried to digest this, but sort of gave up on it :-)
Cheers,
Joost.
Gerd
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users
