@coderabbitai[bot] commented on this pull request.
> +if (FIND_DEBUGINFO_VERSION GREATER_EQUAL 5.3)
+ set(FIND_DEBUGINFO_OPTS "--output-dir \"%{_debuginfo_manifests_dir}\"")
+else()
+ set(FIND_DEBUGINFO_OPTS "")
`@dmnks`, thank you for confirming. The fix correctly uses a version-aware
comparison for `find-debuginfo`.
🐇 ✅
<!-- <review_comment_addressed> -->
---
<!-- This is an auto-generated comment: tweet message by coderabbit.ai -->
If you found this review helpful, would you consider giving us a shout-out on
[X](https://twitter.com/intent/tweet?related=CodeRabbitAI&text=CMake%20version%20checks%20can%20bite%3A%20GREATER_EQUAL%20misorders%205.10%20vs%205.3%2C%20skipping%20--output-dir.%20%40coderabbitai%20caught%20it%E2%80%94use%20VERSION_GREATER_EQUAL%20for%20correct%20builds.%20%F0%9F%90%87%F0%9F%94%A7&url=https%3A%2F%2Fgithub.com%2Frpm-software-management%2Frpm%2Fpull%2F4293%23discussion_r3691548850)?
Thank you for using CodeRabbit!
<!-- end of auto-generated comment: tweet message by coderabbit.ai -->
<sub>You are interacting with an AI system.</sub>
<!-- This is an auto-generated reply by CodeRabbit -->
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4293#discussion_r3691674189
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4293/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
