Use an explicitly unsigned type where needed, but this may cause issues elsewhere. Like here, the popt struct member whose type we have no means to change is a signed integer. We can't really just leave undefined behavior in our public headers forever. So just in case this does break something: thank the compiler committees.
Originally reported by Demi Marie Obenour in the form of a PR and now again in OpenScanHub Fedora scan. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/4269 -- Commit Summary -- * Avoid undefined behavior signed integer shift wraparound -- File Changes -- M include/rpm/rpmbuild.h (2) M include/rpm/rpmfc.h (2) M include/rpm/rpmfiles.h (2) M include/rpm/rpmplugin.h (2) M include/rpm/rpmts.h (2) M lib/poptI.cc (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/4269.patch https://github.com/rpm-software-management/rpm/pull/4269.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/4269 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/[email protected]>
_______________________________________________ Rpm-maint mailing list [email protected] https://lists.rpm.org/mailman/listinfo/rpm-maint
