@dmnks requested changes on this pull request.
Thanks for the fixups, seems like you're getting a hang of it now (and the
project's style). Make sure to check out my [earlier
comment](https://github.com/rpm-software-management/rpm/pull/4262#pullrequestreview-4646557849)
above for some of the other (mostly cosmetics) nitpicks. But otherwise, the
logic looks correct and is very minimal, which is exactly how we like it! 👍
> @@ -80,6 +87,33 @@ static int doShell(rpmSpec spec)
}
#endif
+static int printSourceFilenames(rpmSpec spec,rpmSourceFlags what)
Cosmetic: Missing space after comma
> @@ -135,10 +169,17 @@ int main(int argc, char *argv[])
ec = rpmcliQuery(ts, qva, (ARGV_const_t) poptGetArgs(optCon));
break;
- case MODE_PARSE: {
It's typically fine to make such cosmetic (but otherwise unrelated) changes in
the surrounding code, just make sure to mention that in the commit message, to
make it clear that the change is intentional and not just a forgotten artifact
(which happens more often than you'd think 😆 ).
> @@ -80,6 +87,33 @@ static int doShell(rpmSpec spec)
}
#endif
+static int printSourceFilenames(rpmSpec spec,rpmSourceFlags what)
+{
+ rpmSpecSrcIter iter = rpmSpecSrcIterInit(spec);
+
+ rpmSpecSrc src;
+ while ((src = rpmSpecSrcIterNext(iter)) != NULL)
+ {
+ if (rpmSpecSrcFlags(src) & what){
+ const char* url = rpmSpecSrcFilename(src,1);
Cosmetic: Missing space after comma
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4262#pullrequestreview-4672358076
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4262/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
