@dmnks requested changes on this pull request.
First of all, nice first patch! With that out of the way, let's get to the
roasting part: 😆
Stylistic notes (subjective but established):
- Wrap lines in commit messages at 72 chars (or thereabout)
- Consider using imperative style in commit messages, such as "Add" rather than
"Added" or "Implement" rather than "Implemented"
- Make sure code indentation is correct and consistent with the rest of the
codebase
Implementation notes:
- Document the newly added switches also in the `rpmspec(1)` man page (at
`docs/man/rpmspec.1.scd`)
- We should test also test a spec with the traditional `SourceN` and `PatchN`
directives (`%sources` and `%patches` are later additions). The underlying code
path might be almost the same, but it's still good to have both styles covered
in the test.
- See inline comments for the rest
The stylistic part is kinda documented in CODING_STYLE.md, but not all of the
above, so I think we should actually update it to match the project's style
better (not in this PR of course) 😄
> @@ -412,3 +412,22 @@ rpmspec -P /data/SPECS/preamble-lang.spec
[error: line 4: Unknown tag:
Summary(                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        ):
overflow reproducer
])
RPMTEST_CLEANUP
+
+AT_SETUP([rpmspec --sources and --patches])
Use the `RPMTEST_SETUP`, `RPMTEST_CHECK` and `RPMTEST_CLEANUP` wrappers instead
(as per
[this](https://github.com/rpm-software-management/rpm/blob/master/tests/README.md#writing-tests)).
It happens to work here with the plain `AT_*` macros but that's just because we
don't need to write to the root filesystem in these tests.
> @@ -412,3 +412,22 @@ rpmspec -P /data/SPECS/preamble-lang.spec
[error: line 4: Unknown tag:
Summary(                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        ):
overflow reproducer
])
RPMTEST_CLEANUP
+
+AT_SETUP([rpmspec --sources and --patches])
+AT_KEYWORDS([rpmspec])
+
+AT_CHECK([rpmspec --sources ${abs_srcdir}/data/SPECS/hello-sources.spec],
Stylistic: It's good practice to put test commands on separate lines, like in a
shell script (see other `RPMTEST_CHECK` lines above for inspiration).
> @@ -60,6 +67,13 @@ static struct poptOption optionsTable[] = {
POPT_TABLEEND
};
+struct SpecSrcIterDeleter {
+ void operator()(rpmSpecSrcIter iter) const {
+ rpmSpecSrcIterFree(iter);
+ }
+};
+using SpecSrcIter = std::unique_ptr<rpmSpecIter_s, SpecSrcIterDeleter>;
Like we talked about in the chat, this kind of refactoring isn't inherently
bad, but let's save that for later so that we can do it across the board, to
keep things consistent.
Also, in this particular case, we're basically replacing a
`rpmSpecSrcIterFree(iter)` call with *more* code, so the net benefit (in terms
of LoC) is negative 😅 .
> @@ -80,6 +94,33 @@ static int doShell(rpmSpec spec)
}
#endif
+static int printSpecAddresses(rpmSpec spec, bool printPatches)
+{
+ SpecSrcIter iter(rpmSpecSrcIterInit(spec));
+ if (!iter) return 1;
+ rpmSpecSrc src;
+ while ((src = rpmSpecSrcIterNext(iter.get())) != NULL)
+ {
+ bool isPatch = (rpmSpecSrcFlags(src) & RPMBUILD_ISPATCH) != 0;
+
+ if (isPatch == printPatches){
+ const char* url = rpmSpecSrcFilename(src,1);
I think we should consider making the full/short path return controllable via a
CLI switch, like alluded to in the original ticket #3315. Whether it should be
an additional switch like `--full` or similar, dunno. That's up for discussion,
probably best kept in that ticket.
> @@ -80,6 +94,33 @@ static int doShell(rpmSpec spec)
}
#endif
+static int printSpecAddresses(rpmSpec spec, bool printPatches)
Cosmetic: "Addresses" isn't very self-explanatory. I'd suggest something like
`printSourceFilenames()` or similar.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4262#pullrequestreview-4646557849
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4262/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
