@dmnks commented on this pull request.
> @@ -15,11 +15,11 @@ esac
# Strip .comment and .note sections (the latter only if it is not allocated)
# for already stripped elf files in the build root
-for f in `find "$RPM_BUILD_ROOT" -type f \( -perm -0100 -or -perm -0010 -or
-perm -0001 \) -print0 | xargs -0 -r -P$NCPUS -n32 sh -c "file \"\\$@\" | grep
-v \"^${RPM_BUILD_ROOT}/\?usr/lib/debug\" | sed -n -e 's/^\(.*\):[ ]*ELF.*,
stripped.*/\1/p'" ARG0`; do
+find "$RPM_BUILD_ROOT" -type f \( -perm -0100 -or -perm -0010 -or -perm -0001
\) -print0 | xargs -0 -r -P$NCPUS -n32 sh -c 'for f in $(file $@ | grep -v
"^${RPM_BUILD_ROOT}/\?usr/lib/debug" | sed -n -e "s/^\(.*\):[ ]*ELF.*,
stripped.*/\1/p"); do
One more thing I've noticed: the `$@` argument should be quoted, otherwise it
won't work with filenames with spaces in them.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3869#pullrequestreview-3109433080
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3869/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
