@dmnks commented on this pull request.


>       note="-R .note"
-       if $OBJDUMP -h $f | grep '^[    ]*[0-9]*[       ]*.note[        ]' -A 1 
| \
+       if '$OBJDUMP' -h $f | grep "^[  ]*[0-9]*[       ]*.note[        ]" -A 1 
| \

You're right - these are actually *not* space chars, the content in between the 
square brackets is a character class composed of a single space char and a 
single *tab* char, it just renders as multiple spaces in a text editor and git 
diff output. Enabling the displaying of literal tab chars in my text editor 
confirms this. The reason it's now shown differently is because of the added 
single quotes around `$OBJDUMP`. Nice catch!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3869#discussion_r2269203140
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3869/review/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to