Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24099 )
Change subject: KUDU-3750 python: per-test master/tserver flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24099/1/python/kudu/tests/common.py File python/kudu/tests/common.py: http://gerrit.cloudera.org:8080/#/c/24099/1/python/kudu/tests/common.py@196 PS1, Line 196: shutil.rmtree(cluster_root, True) > In the Kudu C++ test scaffolding, the cluster's data isn't removed if the t Ugh nice catch! As it turns out the Java and Python test's control shell mini cluster does cleanup unconditionally: https://github.com/apache/kudu/blob/07148adc8b1ea21ab089857e39de46f7fa68ddab/src/kudu/tools/tool_action_test.cc#L439-L443 In Java tests there is no manual cleanup, it is done on the control shell mini cluster side unconditionally. I would keep this patch as it is (removed the 'rmtree' as it is no-op). Then: I will fix the control shell mini cluster to have an option to keep test files. Then fix both Java and Python test scafolding to plumb this setting, to have similar control about the test files like we have on the C++ side. For this with the details if filed: KUDU-3755. Does this sound good? -- To view, visit http://gerrit.cloudera.org:8080/24099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I648adcd692b2093e99cb541b9f809ef0bb6bec0f Gerrit-Change-Number: 24099 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 16:42:08 +0000 Gerrit-HasComments: Yes
