Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24099 )
Change subject: KUDU-3750 python: per-test master/tserver flags ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Overall LGTM, just one note on cleaning up test cluster's data directories if test fails. I guess other reviewers might add extra feedback, so adding +1 for this first pass. http://gerrit.cloudera.org:8080/#/c/24099/1/python/kudu/tests/common.py File python/kudu/tests/common.py: http://gerrit.cloudera.org:8080/#/c/24099/1/python/kudu/tests/common.py@196 PS1, Line 196: shutil.rmtree(cluster_root, True) In the Kudu C++ test scaffolding, the cluster's data isn't removed if the test fails. That proved to be useful for debugging and troubleshooting. If it makes sense, consider following the same convention for Python test scaffolding as well. -- To view, visit http://gerrit.cloudera.org:8080/24099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I648adcd692b2093e99cb541b9f809ef0bb6bec0f Gerrit-Change-Number: 24099 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Sat, 14 Mar 2026 03:55:52 +0000 Gerrit-HasComments: Yes
