Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket ...................................................................... Patch Set 1: (2 comments) Thank you for the review. http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc File src/kudu/util/net/diagnostic_socket-test.cc: http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc@133 PS4, Line 133: const auto compare_addresses = [&](DiagnosticSocket::TcpSocketInfo entry) { : if (family == AF_INET) { : // IPv4 comparison : if (src_addr.ipv4_addr().sin_addr.s_addr != entry.src_addr[0] || : INADDR_ANY != entry.dst_addr[0]) { : return false; : } : } else { : // IPv6 comparison : if (memcmp(src_addr.ipv6_addr().sin6_addr.s6_addr, : entry.src_addr, sizeof(entry.src_addr)) != 0 || : > This lambda looks like functionality that could pop up elsewhere. I'm not s I can't think of any additional usage scenario right now. However, if such a need arises in future, it wouldn't harm to add this as a method to appropriate class under that patch. http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h File src/kudu/util/net/diagnostic_socket.h: http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h@64 PS1, Line 64: Sockaddr class fields. > doc nit: maybe explicitly mention ipv6 in the todo as well Sockaddr class supports IPv4, IPv6 and Unix domain family. Replacing the pairs with Sockaddr class would inherently mean supporting sockets from IPv4 or IPv6 family. -- To view, visit http://gerrit.cloudera.org:8080/23021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 10 Sep 2025 06:45:24 +0000 Gerrit-HasComments: Yes
