Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23021/3/src/kudu/util/net/diagnostic_socket-test.cc File src/kudu/util/net/diagnostic_socket-test.cc: http://gerrit.cloudera.org:8080/#/c/23021/3/src/kudu/util/net/diagnostic_socket-test.cc@195 PS3, Line 195: ddr[0], INADDR_ > Curious on why not to use the standard 127.0.0.1, although it doesn't make I don't think it should matter. Both are from 127.0.0.0/8 range that are reserved for loopback addresses. I just kept the same address for IPv4 as before from original change. -- To view, visit http://gerrit.cloudera.org:8080/23021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 05 Aug 2025 06:32:42 +0000 Gerrit-HasComments: Yes
