Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/24168 )
Change subject: PROTOTYPE: Turn off tcmalloc's aggressive decommit ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24168/3/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: http://gerrit.cloudera.org:8080/#/c/24168/3/be/src/runtime/bufferpool/system-allocator.cc@81 PS3, Line 81: bool large_buffer = len % HUGE_PAGE_SIZE == 0; Adjust the name and comments to be clear that it is the size alignment that matters. http://gerrit.cloudera.org:8080/#/c/24168/3/be/src/util/process-memory-util.cc File be/src/util/process-memory-util.cc: http://gerrit.cloudera.org:8080/#/c/24168/3/be/src/util/process-memory-util.cc@61 PS3, Line 61: } Consider adding a yield() here -- To view, visit http://gerrit.cloudera.org:8080/24168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11a6f1a68a49ebb706e5699be9e0ee5f842bf29f Gerrit-Change-Number: 24168 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2026 19:48:43 +0000 Gerrit-HasComments: Yes
