Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24168 )

Change subject: PROTOTYPE: Turn off tcmalloc's aggressive decommit
......................................................................


Patch Set 3:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24168/3/be/src/util/memory-metrics.cc
File be/src/util/memory-metrics.cc:

http://gerrit.cloudera.org:8080/#/c/24168/3/be/src/util/memory-metrics.cc@106
PS3, Line 106:   if ((FLAGS_mmap_buffers || FLAGS_mmap_large_buffers) && 
global_reservations != nullptr) {
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11a6f1a68a49ebb706e5699be9e0ee5f842bf29f
Gerrit-Change-Number: 24168
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 06 Apr 2026 21:22:33 +0000
Gerrit-HasComments: Yes

Reply via email to