Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24062 )
Change subject: IMPALA-14116: Skip NULL in an IN-list against a column of an ORC table ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/24062/8/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24062/8/be/src/exec/orc/hdfs-orc-scanner.cc@1213 PS8, Line 1213: if (dst_ptr == nullptr) return orc::Literal(*predicate_type); > Thanks for pointing this out too! I will change the instantiation to "orc:: Nice catch! This might silently push down a wrong predicate. However, this is currently a dead code since FE won't push down predicates that have CHAR/VARCHAR types (IMPALA-10882). We can simply add a TODO here mentioning that we should handle memory allocation failure correctly. -- To view, visit http://gerrit.cloudera.org:8080/24062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62a631e5aa97132afbe0b184d427ad6bc1a4ad0 Gerrit-Change-Number: 24062 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 24 Mar 2026 00:30:57 +0000 Gerrit-HasComments: Yes
