Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24062 )
Change subject: IMPALA-14116: Skip NULL in IN-list against a string column of ORC table ...................................................................... Patch Set 7: > Patch Set 7: > > > Patch Set 7: > > > > (1 comment) > > > > I have addressed the comment on patch set 5. Let me know if there are > > additional suggestions. Thanks! > > Thanks a lot for the detailed analysis at > https://issues.apache.org/jira/browse/IMPALA-14116?focusedCommentId=18063966&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18063966 > Quanlong! > > Let me know how you would like to fix the issue (via the change to > HdfsScanNode.java, or the change to > HdfsOrcScanner::GetSearchArgumentLiteral()). I think both sides should be fixed. GetSearchArgumentLiteral() is used in many other places, not just for in-list predicate. Probably we can add more regression tests on it. -- To view, visit http://gerrit.cloudera.org:8080/24062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62a631e5aa97132afbe0b184d427ad6bc1a4ad0 Gerrit-Change-Number: 24062 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 01:02:35 +0000 Gerrit-HasComments: No
