Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 48: Code-Review+1 (1 comment) Thanks for making the change. Can this merge separately from the next one? Or they should merge together? http://gerrit.cloudera.org:8080/#/c/21803/48/fe/src/main/java/org/apache/impala/service/Canceller.java File fe/src/main/java/org/apache/impala/service/Canceller.java: http://gerrit.cloudera.org:8080/#/c/21803/48/fe/src/main/java/org/apache/impala/service/Canceller.java@20 PS48, Line 20: import static org.apache.impala.util.TUniqueIdUtil.PrintId; : : import com.google.common.base.Preconditions; : import java.util.HashMap; : import java.util.HashSet; : import java.util.concurrent.ExecutionException; : import java.util.concurrent.Future; : import java.util.concurrent.locks.Lock; : : import org.apache.impala.common.UserCancelledException; : import org.apache.impala.thrift.TUniqueId; : import org.slf4j.Logger; : import org.slf4j.LoggerFactory; nit: since this is new file, it might be best to follow import order suggested by from clang-format. import static org.apache.impala.util.TUniqueIdUtil.PrintId; import com.google.common.base.Preconditions; import org.apache.impala.common.UserCancelledException; import org.apache.impala.thrift.TUniqueId; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.util.HashMap; import java.util.HashSet; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.concurrent.locks.Lock; clang-format also suggest some other optional formatting. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 48 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 13 Jun 2025 23:00:14 +0000 Gerrit-HasComments: Yes
