Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 46: (1 comment) http://gerrit.cloudera.org:8080/#/c/21803/43/fe/src/main/java/org/apache/impala/service/Canceller.java File fe/src/main/java/org/apache/impala/service/Canceller.java: http://gerrit.cloudera.org:8080/#/c/21803/43/fe/src/main/java/org/apache/impala/service/Canceller.java@44 PS43, Line 44: // Registers threads by their query ID so the threads can be interrupted on : // cancellation. : private static ConcurrentHashMap<TUniqueId, Thread> : queryThreads_ = new ConcurrentHashMap<>(); : // Registers that the specified thread has been cancelled and should clean up. : private static Set<Thread> cancelledThreads_ = ConcurrentHashMap.newKeySet(); > Is it possible to have Canceller class as singleton instead, and compose th It's already a singleton. Synchronizing unregister/cancel would simplify things a bit, but also introduce additional contention points. That might be minor. I'll consider it some more. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 46 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 06 Jun 2025 22:12:54 +0000 Gerrit-HasComments: Yes
