@1ec5 commented on this pull request.


> +      $("<a>")
+        .attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+        .append($("<img>").attr({ src: OSM.WIKIMEDIA_COMMONS_URL + 
"Special:FilePath/" + data.icon, height: "32" }))
+        .addClass("float-end mb-1 ms-2")
+        .appendTo(cell);
+    }
+    if (data.label) {
+      $btn
+        .siblings(`a[href*="wikidata.org/entity/${data.qid}"]`)
+        .clone()
+        .text(data.label)
+        .addClass("me-1")
+        .appendTo(cell);
+    }
+    if (data.article) {
+      $(`<${data.label ? "sup" : "div"}>`)

I guess I was thinking of something like this (for English), based on how 
Wikidata formats labels on its own site:

* [Bench](https://www.wikidata.org/wiki/Q816714) 
([Wikipedia](https://en.wikipedia.org/wiki/Bench_(British_clothing_brand)))
* [Shell](https://www.wikidata.org/wiki/Q110716465)
* [Q111384397](https://www.wikidata.org/wiki/Q111384397)

The QID would be redundant to what’s in the normal tag view, though…

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2184105261
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6127/review/2985158...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to