@1ec5 commented on this pull request.
> + $("<a>")
+ .attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" +
encodeURIComponent(data.icon))
+ .append($("<img>").attr({ src, height: "32" }))
+ .addClass("float-end mb-1 ms-2")
+ .appendTo(cell);
+ }
+ if (data.label) {
+ $btn
+ .siblings(`a[href*="wikidata.org/entity/${data.qid}"]`)
+ .clone()
+ .text(data.label)
+ .addClass("me-1")
+ .appendTo(cell);
+ }
+ if (data.article) {
+ const lang = data.article.site.slice(0, -4);
I think this is fine, since lots of Wikimedia-related software makes the same
assumption. It just needs a comment explaining the magic number −4.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2184073867
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6127/review/2985126...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
