mnalis left a comment (openstreetmap/openstreetmap-website#5904)
**TL;DR:** great for adding support for adding/changing (optional) tags on
notes, as well as (optional) extra API params / website changes to filter by
them; but please no mutable note texts/coordinates - it would be quite
problematic!
---
Thanks for clarifications @nenad-vujicic !
> - At the moment mappers use hash-tags. In near future we could use buttons
> for creating / updating / deleting note tags. Similarly for reading, instead
> of passing through note-comments, we will have a table like for elements
> (this is implemented).
I agree; adding tags to notes is useful feature. Data consumers which do not
implement that extension would still be able to use all existing functionality
in the same way, so would only miss on those extensions.
> - At the moment mappers manually search / filter notes. In near future we
> could use UI for defining searching / filtering criterias.
Having an API extension being able to also filter by those tags would be nice
addition, getting around limitation of maxnotes and local filtering etc.
(provided it reduces the server load instead of increasing it). Also, data
consumers which do not implement those search extensions would retain same
functionality as before, so this sounds good to me too.
> - At the moment mappers manually inspect notes or use 3rd party tools. We
> already have implemented (in this PR) retrieving particular note's version,
> which gives us a chance to build note's history viewers / analyzers for
> automatizing parts of note's inspection.
**Mutable text/coordinates of Notes however looks highly problematic to me.**
Notes are currently journal-like implementation, i.e. only new comments can be
added, and old ones cannot be changed. I think making the comments and
coordinates mutable would be very bad. It is IMHO **not comparable to elements
(nodes/ways/relations) versioning**, as those are self-contained and **do not
have dependent subelements**. But notes have: each note comment is dependent
"subelement", i.e. meaning of each note "reply" **depends** on the content of
**coordinates and original texts of ALL preceding comments**, and **not** on
their latest version!
Changing the text or coordinates of an original note (or previous comment) at a
later time, (potentially) changes the meaning of all comments that were written
between time where original text was written and its updated version. Also,
some apps cache notes offline, which would further make determining on which
version the reply was made problematic. Also, one should consider that there
will be both old API apps and new API apps running at the same time for
forseeable future, so they would need to work together without stepping on each
other toes.
I.e. in current Notes system it is extremely easy and efficient to follow the
temporal ordering of events, just follow the "comments" by increasing
ids/timestamps. Any clarifications or corrections are just another comment down
the line.
Making the comments text or coordinates mutable would totally break the
workflow of all existing note consumers, and require all consumerts to convert
to new API _and_ also invest significant effort to make sense of and avoid
misinterpreting Notes, for no good reason.
Also, how would the [Notes planet
dump](https://planet.openstreetmap.org/notes/) change with mutable notes? It
seems like a drastic change, perhaps even necessitating splitting to separate
planet-notes and history-notes as we have for elements (compared to e.g. mere
adding of note tags, which would probably just add "tags=" attribute to
appropriate XML element, which would work as-is in most if not all data
consumers, and is trivial change)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2877798403
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5904/c2877798...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
