mnalis left a comment (openstreetmap/openstreetmap-website#5904)
I think this PR would benefit from outlying in more details exactly ***why***
is it doing changes (i.e. what exactly new user-requested functionality will
become available), instead of just enumerating low-level technical steps which
are being done. Judging by few words and linked PR discussion, I guess it
might have something to do with enabling users to add tags to notes and thus
making notes mutable, but I cannot really tell what is an actual idea being
implemented, and what are technical side-effects.
> plus update functionality (we would have new event type - update) something
> you would like?
I don't think that notes would benefit from being changed, in fact it would
likely be very bad. I.e. if note could be moved or its description changed,
followup comments could be misunderstood or turned out of context. Also, it
would make necessery not only API/UI to see what changes were being made and
when, but a new (or extended) planet.osm.org dump (like we have e.g.
`planet-*.bz2` as well as `history-*.bz2` for nodes/ways/relations).
Only part of Note that should be modifiable IMHO is implementing #hashtags, the
rest of the notes should better remain immutable. Having versions, locations
and descriptions being change are IMHO likely to introduce much more chaos then
help.
**TL;DR:** can you list example use-cases and how this PR addresses them (i.e.
_"users currently do this thing xxxxx which is inconvenient, and with those
changes implemented they will be able do this other thing which is
easier/better because yyyy"_)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2858692186
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5904/c2858692...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
