@AntonKhorev commented on this pull request.


>  
-        for (const layer of this._bboxLayers) {
-          layer.updateChangesetLayerBounds(changeset);

Because `updateChangesetsOrder` clears all bbox layers and adds the necessary 
bboxes again.

Previously it wasn't necessary in response to non-zoom map movement because the 
bbox layers didn't change. Therefore `updateChangesetLocations` didn't call 
`updateChangesetsOrder` aka `reorderChangesets`.

Now you can move from a view where an edge of a bbox is visible and its area 
layer should be added to a view where the same edge is no longer visible and 
the area layer shouldn't be added.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5981#discussion_r2074580812
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5981/review/2816635...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to