On Mon, Sep 2, 2013 at 1:37 AM, peter dalgaard <pda...@gmail.com> wrote: > > On Sep 2, 2013, at 00:42 , Duncan Murdoch wrote: > >> On 13-09-01 3:53 PM, peter dalgaard wrote: >>> >>> On Sep 1, 2013, at 20:08 , Duncan Murdoch wrote: >>> >>>> On 13-09-01 2:45 AM, Scott Kostyshak wrote: >>>>> 'tkcoords' is defined twice (in the same way) in src/library/tcltk/R/Tk.R. >>>>> >>>>> Attached is a patch against r63780 that removes the duplicate >>>>> definition and alphabetizes the functions. >>>>> >>>>> I've read that minor patches such as this should be sent to r-devel [1]. >>>>> >>>>> Scott >>>>> >>>>> [1] http://permalink.gmane.org/gmane.comp.lang.r.devel/33987 >>>> >>>> Thanks. I would not do the alphabetization; that makes it much harder to >>>> track changes. But if tkcoords is unnecessarily duplicated, that seems >>>> like a reasonable change. >>>> >>> >>> That's what I thought at first sight, but actually, the current breach of >>> alphabetization is quite slight, so might be worth fixing after all, since >>> it helps against putting the same function in twice... (the patch has >>> tkpostcascade before tkpost, which is wrong, though). >> >> In that case, go ahead. I didn't look at the patch due to the description. >> (I have committed the removal of the dupe.)
Thanks. >> > > OK, done. R-devel only, like your change. Thanks, Scott -- Scott Kostyshak Economics PhD Candidate Princeton University ______________________________________________ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel
