On Sep 1, 2013, at 20:08 , Duncan Murdoch wrote:

> On 13-09-01 2:45 AM, Scott Kostyshak wrote:
>> 'tkcoords' is defined twice (in the same way) in src/library/tcltk/R/Tk.R.
>> 
>> Attached is a patch against r63780 that removes the duplicate
>> definition and alphabetizes the functions.
>> 
>> I've read that minor patches such as this should be sent to r-devel [1].
>> 
>> Scott
>> 
>> [1] http://permalink.gmane.org/gmane.comp.lang.r.devel/33987
> 
> Thanks.  I would not do the alphabetization; that makes it much harder to 
> track changes.  But if tkcoords is unnecessarily duplicated, that seems like 
> a reasonable change.
> 

That's what I thought at first sight, but actually, the current breach of 
alphabetization is quite slight, so might be worth fixing after all, since it 
helps against putting the same function in twice... (the patch has 
tkpostcascade before tkpost, which is wrong, though).

-pd

> Duncan Murdoch
> 
> ______________________________________________
> R-devel@r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel

-- 
Peter Dalgaard, Professor,
Center for Statistics, Copenhagen Business School
Solbjerg Plads 3, 2000 Frederiksberg, Denmark
Phone: (+45)38153501
Email: pd....@cbs.dk  Priv: pda...@gmail.com

______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Reply via email to