Markus Armbruster <[email protected]> writes: > Fabiano Rosas <[email protected]> writes: > >> Signed-off-by: Fabiano Rosas <[email protected]> >> --- >> qapi/migration.json | 20 ++++++++++++++++++-- >> 1 file changed, 18 insertions(+), 2 deletions(-) >> >> diff --git a/qapi/migration.json b/qapi/migration.json >> index c352c7ac52..602cb706e3 100644 >> --- a/qapi/migration.json >> +++ b/qapi/migration.json >> @@ -1519,10 +1519,25 @@ >> # >> # @rdma: Migrate via RDMA. >> # >> +# @file: Direct the migration stream to a file. >> +# >> # Since 8.2 >> ## >> { 'enum': 'MigrationAddressType', >> - 'data': ['socket', 'exec', 'rdma'] } >> + 'data': ['socket', 'exec', 'rdma', 'file'] } > > I don't like our use of spaces around parenthesis in the QAPI schema, > but I like inconsistency even less: please insert a space after '['. >
Yes. But, a contributor today has to guess what is the preferred syntax. Could we have a checkpatch rule for this? Or should I send a patch to make the whole file consistent at once? Side question: are we using valid JSON at all? I threw this in a random online linter and it complains about the single quotes. We could have a proper tool doing the validation in CI.
