Fabiano Rosas <[email protected]> writes:
> Signed-off-by: Fabiano Rosas <[email protected]>
> ---
> qapi/migration.json | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index c352c7ac52..602cb706e3 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1519,10 +1519,25 @@
> #
> # @rdma: Migrate via RDMA.
> #
> +# @file: Direct the migration stream to a file.
> +#
> # Since 8.2
> ##
> { 'enum': 'MigrationAddressType',
> - 'data': ['socket', 'exec', 'rdma'] }
> + 'data': ['socket', 'exec', 'rdma', 'file'] }
I don't like our use of spaces around parenthesis in the QAPI schema,
but I like inconsistency even less: please insert a space after '['.
> +
> +##
> +# @FileMigrationArgs:
> +#
> +# @path: file path
Name this @filename for local consistency. We use both @filename and
@path for filenames in the schema, which is sad. However,
migration.json uses only @filename so far. Let's keep it that way.
"file path" is awfully terse. Maybe "file to receive the migration
stream"?
> +#
> +# @offset: initial offset for the file
Again, too terse. How is @offset to be used? Start writing at this
file offset?
> +#
> +# Since 8.2
> +##
> +{ 'struct': 'FileMigrationArgs',
> + 'data': {'path': 'str',
Please insert a space after '{', and reindent the next line.
> + 'offset': 'uint64' } }
>
> ##
> # @MigrationExecCommand:
> @@ -1547,7 +1562,8 @@
> 'data': {
> 'socket': 'SocketAddress',
> 'exec': 'MigrationExecCommand',
> - 'rdma': 'InetSocketAddress' } }
> + 'rdma': 'InetSocketAddress',
> + 'file': 'FileMigrationArgs' } }
>
> ##
> # @migrate:
