On 10/17/23 18:29, BALATON Zoltan wrote:
On Tue, 17 Oct 2023, [email protected] wrote:
From: Helge Deller <[email protected]>
Allow the Astro source to be built.
It was addded 3 patches earlier. Shuold this also be in that patch or at least
closer to it?
I will move it closer.
Helge
If you think that patch is too big (which it maybe is) it could help to split
up to simpler patches but not sure moving out build system and MAINTAINERS
changes realy does simplify the patch for review. This are trivial even if in
the same patch so I would not bother putting this in separate patch unless
there's some other reason I've missed.
If you want to split that patch up to make it easier to review maybe try having
one patch adding skeleton or basic device first, then more patches adding more
functionality to it which may seem to be better than just having these in
separate patches later in the series.
Regards,
BALATON Zoltan
Signed-off-by: Helge Deller <[email protected]>
---
hw/hppa/Kconfig | 1 +
hw/pci-host/Kconfig | 4 ++++
hw/pci-host/meson.build | 1 +
3 files changed, 6 insertions(+)
diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
index 5dd8b5b21e..ff8528aaa8 100644
--- a/hw/hppa/Kconfig
+++ b/hw/hppa/Kconfig
@@ -3,6 +3,7 @@ config HPPA_B160L
imply PCI_DEVICES
imply E1000_PCI
imply VIRTIO_VGA
+ select ASTRO
select DINO
select LASI
select SERIAL
diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
index a07070eddf..54a609d2ca 100644
--- a/hw/pci-host/Kconfig
+++ b/hw/pci-host/Kconfig
@@ -82,6 +82,10 @@ config DINO
bool
select PCI
+config ASTRO
+ bool
+ select PCI
+
config GT64120
bool
select PCI
diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build
index 64eada76fe..f891f026cb 100644
--- a/hw/pci-host/meson.build
+++ b/hw/pci-host/meson.build
@@ -27,6 +27,7 @@ pci_ss.add(when: 'CONFIG_MV64361', if_true:
files('mv64361.c'))
pci_ss.add(when: 'CONFIG_VERSATILE_PCI', if_true: files('versatile.c'))
# HPPA devices
+pci_ss.add(when: 'CONFIG_ASTRO', if_true: files('astro.c'))
pci_ss.add(when: 'CONFIG_DINO', if_true: files('dino.c'))
system_ss.add_all(when: 'CONFIG_PCI', if_true: pci_ss)
