Re: [PATCH v2 05/11] lasips2: LASI PS/2 devices are not user-createable

[BALATON Zoltan]

On Tue, 17 Oct 2023, del...@kernel.org wrote:
From: Helge Deller <del...@gmx.de>
Those PS/2 ports are created with the LASI controller when
a 32-bit PA-RISC machine is created.

Mark them not user-createable to avoid showing them in
the qemu device list.

Signed-off-by: Helge Deller <del...@gmx.de>
Cc: qemu-sta...@nongnu.org
---
hw/input/lasips2.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c
index ea7c07a2ba..18b94fa060 100644
--- a/hw/input/lasips2.c
+++ b/hw/input/lasips2.c
@@ -351,6 +351,7 @@ static void lasips2_port_class_init(ObjectClass *klass, 
void *data)
{
    DeviceClass *dc = DEVICE_CLASS(klass);


This isn't what I've meant but maybe I could not explain it clearly. 
According to include/hw/qdev-core.h these should have a comment explaining 
why but a comment just saying "this isn't user creatable" does not explain 
it. Instead the comment should say why, e.g. Part of LASI, not a separate 
device or whatever the reason these aren't QDEVs that the user should 
handle.

Regards,
BALATON Zoltan

+    dc->user_creatable = false;
    dc->realize = lasips2_port_realize;
}

@@ -397,6 +398,7 @@ static void lasips2_kbd_port_class_init(ObjectClass *klass, 
void *data)
    DeviceClass *dc = DEVICE_CLASS(klass);
    LASIPS2PortDeviceClass *lpdc = LASIPS2_PORT_CLASS(klass);

+    dc->user_creatable = false;
    device_class_set_parent_realize(dc, lasips2_kbd_port_realize,
                                    &lpdc->parent_realize);
}