On Thu, 20 Jul 2023 at 08:16, xianglai li <[email protected]> wrote: > > It introduces a new function to unwire the > vcpu<->exioi interrupts for the vcpu hot-(un)plug cases. > > Cc: Xiaojuan Yang <[email protected]> > Cc: Song Gao <[email protected]> > Cc: "Michael S. Tsirkin" <[email protected]> > Cc: Igor Mammedov <[email protected]> > Cc: Ani Sinha <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Cc: Richard Henderson <[email protected]> > Cc: Eduardo Habkost <[email protected]> > Cc: Marcel Apfelbaum <[email protected]> > Cc: "Philippe Mathieu-Daudé" <[email protected]> > Cc: Yanan Wang <[email protected]> > Cc: "Daniel P. Berrangé" <[email protected]> > Cc: Peter Xu <[email protected]> > Cc: David Hildenbrand <[email protected]> > Signed-off-by: xianglai li <[email protected]> > --- > hw/core/gpio.c | 4 ++-- > include/hw/qdev-core.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/core/gpio.c b/hw/core/gpio.c > index 80d07a6ec9..4fc6409545 100644 > --- a/hw/core/gpio.c > +++ b/hw/core/gpio.c > @@ -143,8 +143,8 @@ qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, > const char *name, int n) > > /* disconnect a GPIO output, returning the disconnected input (if any) */ > > -static qemu_irq qdev_disconnect_gpio_out_named(DeviceState *dev, > - const char *name, int n) > +qemu_irq qdev_disconnect_gpio_out_named(DeviceState *dev, > + const char *name, int n) > { > char *propname = g_strdup_printf("%s[%d]", > name ? name : "unnamed-gpio-out", n);
This function as currently written is intended only for use in qdev_intercept_gpio_out(), which in turn is there only for qtest test case use. I would be a bit cautious about whether there are unexpected issues with trying to use it in "production" functionality with a running QEMU (eg when perhaps some device might be trying to signal the gpio line in another thread while this one is trying to disconnect it). thanks -- PMM
