On Thu, 20 Jul 2023 15:15:08 +0800 xianglai li <[email protected]> wrote:
> It introduces a new function to unwire the > vcpu<->exioi interrupts for the vcpu hot-(un)plug cases. it's not a new function. You probably wanted to say: subj: make foo() public it will be reused .someplace. for ... > > Cc: Xiaojuan Yang <[email protected]> > Cc: Song Gao <[email protected]> > Cc: "Michael S. Tsirkin" <[email protected]> > Cc: Igor Mammedov <[email protected]> > Cc: Ani Sinha <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Cc: Richard Henderson <[email protected]> > Cc: Eduardo Habkost <[email protected]> > Cc: Marcel Apfelbaum <[email protected]> > Cc: "Philippe Mathieu-Daudé" <[email protected]> > Cc: Yanan Wang <[email protected]> > Cc: "Daniel P. Berrangé" <[email protected]> > Cc: Peter Xu <[email protected]> > Cc: David Hildenbrand <[email protected]> > Signed-off-by: xianglai li <[email protected]> > --- > hw/core/gpio.c | 4 ++-- > include/hw/qdev-core.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/core/gpio.c b/hw/core/gpio.c > index 80d07a6ec9..4fc6409545 100644 > --- a/hw/core/gpio.c > +++ b/hw/core/gpio.c > @@ -143,8 +143,8 @@ qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, > const char *name, int n) > > /* disconnect a GPIO output, returning the disconnected input (if any) */ > > -static qemu_irq qdev_disconnect_gpio_out_named(DeviceState *dev, > - const char *name, int n) > +qemu_irq qdev_disconnect_gpio_out_named(DeviceState *dev, > + const char *name, int n) > { > char *propname = g_strdup_printf("%s[%d]", > name ? name : "unnamed-gpio-out", n); > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index 884c726a87..992f5419fa 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -739,6 +739,8 @@ qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, > const char *name, int n); > */ > qemu_irq qdev_intercept_gpio_out(DeviceState *dev, qemu_irq icpt, > const char *name, int n); > +qemu_irq qdev_disconnect_gpio_out_named(DeviceState *dev, > + const char *name, int n); watch for proper alignment have you tried to run ./scripts/checkpatch.pl on you series? (it should catch such cases) > > BusState *qdev_get_child_bus(DeviceState *dev, const char *name); >
