> -----Original Message----- > From: Akihiko Odaki <[email protected]> > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman <[email protected]>; Jason Wang > <[email protected]>; Dmitry Fleytman <[email protected]>; > Michael S. Tsirkin <[email protected]>; Alex Bennée <[email protected]>; > Philippe Mathieu-Daudé <[email protected]>; Thomas Huth > <[email protected]>; Wainer dos Santos Moschetta > <[email protected]>; Beraldo Leal <[email protected]>; Cleber Rosa > <[email protected]>; Laurent Vivier <[email protected]>; Paolo Bonzini > <[email protected]>; [email protected]; Akihiko Odaki > <[email protected]> > Subject: [PATCH 19/40] igb: Read DCMD.VLE of the first Tx descriptor > > Section 7.2.2.3 Advanced Transmit Data Descriptor says: > > For frames that spans multiple descriptors, all fields apart from > > DCMD.EOP, DCMD.RS, DCMD.DEXT, DTALEN, Address and DTYP are valid only > > in the first descriptors and are ignored in the subsequent ones. > > Signed-off-by: Akihiko Odaki <[email protected]> > --- > hw/net/igb_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index > cca71611fe..e5a7021c0e 100644 > --- a/hw/net/igb_core.c > +++ b/hw/net/igb_core.c > @@ -613,7 +613,7 @@ igb_process_tx_desc(IGBCore *core, > idx = (tx->first_olinfo_status >> 4) & 1; > igb_tx_insert_vlan(core, queue_index, tx, > tx->ctx[idx].vlan_macip_lens >> 16, > - !!(cmd_type_len & E1000_TXD_CMD_VLE)); > + !!(tx->first_cmd_type_len & E1000_TXD_CMD_VLE)); > > if (igb_tx_pkt_send(core, tx, queue_index)) { > igb_on_tx_done_update_stats(core, tx->tx_pkt, queue_index); > -- > 2.40.0
Reviewed-by: Sriram Yagnaraman <[email protected]>
