On 2/7/23 06:00, Peter Maydell wrote:
On Tue, 24 Jan 2023 at 00:01, Richard Henderson <[email protected]> wrote:Integrate neighboring code from get_phys_addr_lpae which computed starting level, as it is easier to validate when doing both at the same time. Mirror the checks at the start of AArch{64,32}.S2Walk, especially S2InvalidESL and S2InconsistentSL. This reverts 49ba115bb74, which was incorrect -- there is nothing in the ARM pseudocode that depends on TxSZ, i.e. outputsize; the pseudocode is consistent in referencing PAMax.I'm having difficulty reviewing this one: * the latest version of the Arm ARM doesn't have the pseudocode functions you refer to, so it's difficult to cross-refer against the spec
DDI 0478 I.a certainly does have them (typo: S2InvalidSL not S2InvalidESL). r~
