On Tue, 24 Jan 2023 at 00:01, Richard Henderson <[email protected]> wrote: > > Integrate neighboring code from get_phys_addr_lpae which computed > starting level, as it is easier to validate when doing both at the > same time. Mirror the checks at the start of AArch{64,32}.S2Walk, > especially S2InvalidESL and S2InconsistentSL. > > This reverts 49ba115bb74, which was incorrect -- there is nothing > in the ARM pseudocode that depends on TxSZ, i.e. outputsize; the > pseudocode is consistent in referencing PAMax.
I'm having difficulty reviewing this one: * the latest version of the Arm ARM doesn't have the pseudocode functions you refer to, so it's difficult to cross-refer against the spec * the changes are too large for it to be easy to confirm what's just been refactored into the other function and what (if any) the behavioural changes are thanks -- PMM
