Marc-André Lureau <[email protected]> writes: > On Tue, Aug 31, 2021 at 4:38 PM Markus Armbruster <[email protected]> wrote: > >> Markus Armbruster (12): >> qapi: Simplify QAPISchemaIfCond's interface for generating C >> qapi: Simplify how QAPISchemaIfCond represents "no condition" >> tests/qapi-schema: Correct two 'if' conditionals >> tests/qapi-schema: Demonstrate broken C code for 'if' >> qapi: Fix C code generation for 'if' >> qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond() >> qapi: Avoid redundant parens in code generated for conditionals >> qapi: Use "not COND" instead of "!COND" for generated documentation >> qapi: Use re.fullmatch() where appropriate >> tests/qapi-schema: Hide OrderedDict in test output >> qapi: Tweak error messages for missing / conflicting meta-type >> qapi: Tweak error messages for unknown / conflicting 'if' keys >> >> scripts/qapi/common.py | 51 ++++++++++++++----------- >> scripts/qapi/expr.py | 32 +++++++--------- >> scripts/qapi/gen.py | 6 +-- >> scripts/qapi/introspect.py | 6 +-- >> scripts/qapi/schema.py | 12 +++++- >> scripts/qapi/types.py | 22 +++++------ >> scripts/qapi/visit.py | 14 +++---- >> tests/qapi-schema/bad-if-key.err | 2 +- >> tests/qapi-schema/bad-if-keys.err | 2 +- >> tests/qapi-schema/doc-good.json | 2 +- >> tests/qapi-schema/doc-good.out | 6 +-- >> tests/qapi-schema/doc-good.txt | 8 ++-- >> tests/qapi-schema/double-type.err | 4 +- >> tests/qapi-schema/enum-if-invalid.err | 2 +- >> tests/qapi-schema/missing-type.err | 2 +- >> tests/qapi-schema/qapi-schema-test.json | 9 +++-- >> tests/qapi-schema/qapi-schema-test.out | 31 ++++++++------- >> tests/qapi-schema/test-qapi.py | 11 +++++- >> 18 files changed, 118 insertions(+), 104 deletions(-) >> >> > The first patch, you should apply isort
Will fix. > The first patch, you should apply isort (we should have a check for that > and linters I suppose). John will get us there. > Series: > Reviewed-by: Marc-André Lureau <[email protected]> Thanks!
