On 5/26/21 10:22 AM, Philippe Mathieu-Daudé wrote:
What do the extra ifdefs buy us? Surely the fact that the symbol is not
present in the user-only, and would produce link errors if used, is
sufficient?
Last month on another series you told me we should declare prototypes
that can't be used :) However I agree we want *less* #ifdef'ry, not
more.
Should or shouldn't?
Anyway, I don't think any of these declarations belong in cpu.h. There's no
reason for any external user to reference them, as they ought to be using the
hw/core/ cpu_* functions.
In an ideal world, we'd move them into some target/foo/sysemu/internal.h or
something, which would involve no ifdefs and still give you the isolation.
But for the bulk of the targets, I think it's just easier to leave them alone.
r~
