On 5/26/21 4:12 AM, Richard Henderson wrote:
> On 5/17/21 3:51 AM, Philippe Mathieu-Daudé wrote:
>> In commit cbc183d2d9f ("cpu: move cc->transaction_failed to tcg_ops")
>> we restricted the do_transaction_failed() handler to the sysemu part
>> of TCGCPUOps, but forgot to restrict the target specific declarations.
>>
>> Signed-off-by: Philippe Mathieu-Daudé<[email protected]>
>> ---
>> target/arm/internals.h | 2 ++
>> target/m68k/cpu.h | 2 ++
>> target/riscv/cpu.h | 10 +++++-----
>> target/xtensa/cpu.h | 8 ++++----
>> 4 files changed, 13 insertions(+), 9 deletions(-)
>
> What do the extra ifdefs buy us? Surely the fact that the symbol is not
> present in the user-only, and would produce link errors if used, is
> sufficient?
Last month on another series you told me we should declare prototypes
that can't be used :) However I agree we want *less* #ifdef'ry, not
more.
The ARM declarations is fixed in Claudio's accel rework.
For the m68k/riscv/xtensa targets I'll see if I can move it elsewhere
in the same file (if there is already such #ifdef'ry), it is worthwhile
to move the declaration in another (sysemu) header, or simply do
nothing.
Thanks,
Phil.
