Hi Peter, > -----Original Message----- > From: Peter Maydell <[email protected]> > Sent: Tuesday, December 1, 2020 4:53 PM > To: Sai Pavan Boddu <[email protected]> > Cc: Markus Armbruster <[email protected]>; Marc-André Lureau > <[email protected]>; Paolo Bonzini <[email protected]>; > Gerd Hoffmann <[email protected]>; Edgar Iglesias <[email protected]>; > Francisco Eduardo Iglesias <[email protected]>; Alistair Francis > <[email protected]>; Eduardo Habkost <[email protected]>; Ying > Fang <[email protected]>; Philippe Mathieu-Daudé > <[email protected]>; Vikram Garhwal <[email protected]>; Paul Zimmerman > <[email protected]>; Sai Pavan Boddu <[email protected]>; QEMU > Developers <[email protected]> > Subject: Re: [PATCH v14 1/4] usb: Add versal-usb2-ctrl-regs module > > On Tue, 1 Dec 2020 at 08:34, Sai Pavan Boddu <[email protected]> > wrote: > > > > This module emulates control registers of versal usb2 controller, this > > is added just to make guest happy. In general this module would > > control the phy-reset signal from usb controller, data coherency of > > the transactions, signals the host system errors received from controller. > > > > Signed-off-by: Sai Pavan Boddu <[email protected]> > > Signed-off-by: Vikram Garhwal <[email protected]> > > Reviewed-by: Edgar E. Iglesias <[email protected]> > > --- > > hw/usb/meson.build | 1 + > > hw/usb/xlnx-versal-usb2-ctrl-regs.c | 229 > ++++++++++++++++++++++++++++ > > include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 45 ++++++ > > 3 files changed, 275 insertions(+) > > create mode 100644 hw/usb/xlnx-versal-usb2-ctrl-regs.c > > create mode 100644 include/hw/usb/xlnx-versal-usb2-ctrl-regs.h > > Reviewed-by: Peter Maydell <[email protected]> [Sai Pavan Boddu] Thanks for the review.
Regards, Sai Pavan > > thanks > -- PMM
