Hi Peter, > -----Original Message----- > From: Peter Maydell <[email protected]> > Sent: Tuesday, December 1, 2020 4:56 PM > To: Sai Pavan Boddu <[email protected]> > Cc: Markus Armbruster <[email protected]>; Marc-André Lureau > <[email protected]>; Paolo Bonzini <[email protected]>; > Gerd Hoffmann <[email protected]>; Edgar Iglesias <[email protected]>; > Francisco Eduardo Iglesias <[email protected]>; Alistair Francis > <[email protected]>; Eduardo Habkost <[email protected]>; Ying > Fang <[email protected]>; Philippe Mathieu-Daudé > <[email protected]>; Vikram Garhwal <[email protected]>; Paul Zimmerman > <[email protected]>; Sai Pavan Boddu <[email protected]>; QEMU > Developers <[email protected]> > Subject: Re: [PATCH v14 2/4] usb: Add DWC3 model > > On Tue, 1 Dec 2020 at 08:34, Sai Pavan Boddu <[email protected]> > wrote: > > > > From: Vikram Garhwal <[email protected]> > > > > This patch adds skeleton model of dwc3 usb controller attached to > > xhci-sysbus device. It defines global register space of DWC3 > > controller, global registers control the AXI/AHB interfaces > > properties, external FIFO support and event count support. All of > > which are unimplemented at present,we are only supporting core reset and > read of ID register. > > > > Signed-off-by: Vikram Garhwal <[email protected]> > > Signed-off-by: Sai Pavan Boddu <[email protected]> > > Reviewed-by: Edgar E. Iglesias <[email protected]> > > --- > > > > +typedef struct USBDWC3 { > > + SysBusDevice parent_obj; > > + MemoryRegion iomem; > > + MemoryRegion fifos; > > + XHCISysbusState sysbus_xhci; > > + > > + uint32_t regs[USB_DWC3_R_MAX]; > > + RegisterInfo regs_info[USB_DWC3_R_MAX]; > > This device has state but is missing the VMState struct support for migration. > Otherwise it looks OK. [Sai Pavan Boddu] Ok, I will fix this in V15
Thanks, Sai Pavan > > thanks > -- PMM
