On 10/29/20 8:38 AM, Markus Armbruster wrote:
> The test covers only two out of nine combinations. Test all nine.
> Four turn out to be broken. Marked /* BUG */.
>
> Signed-off-by: Markus Armbruster <[email protected]>
> ---
> tests/test-util-sockets.c | 86 ++++++++++++++++++++++++++++-----------
> 1 file changed, 63 insertions(+), 23 deletions(-)
>
> -static void test_socket_unix_abstract_good(void)
> +static void test_socket_unix_abstract(void)
> {
> - SocketAddress addr;
> + SocketAddress addr, addr_tight, addr_padded;
> + abstract_socket_matrix_row matrix[ABSTRACT_SOCKET_VARIANTS] = {
> + { &addr,
> + { &addr_tight, &addr_padded, &addr },
> + { false /* BUG */, true /* BUG */, true } },
> + { &addr_tight,
> + { &addr_padded, &addr, &addr_tight },
> + { false, false /* BUG */, true } },
> + { &addr_padded,
> + { &addr, &addr_tight, &addr_padded },
> + { true /* BUG */, false, true } }
> + };
> + int i;
>
Reviewed-by: Eric Blake <[email protected]>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
