On 10/29/20 8:38 AM, Markus Armbruster wrote: > The abstract sockets test spawns a thread to listen and a accept, and
s/and a/and/ > a second one to connect, with a sleep(1) in between to "ensure" the > former is listening when the latter tries to connect. Review fail. > Risks spurious test failure, say when a heavily loaded machine doesn't > schedule the first thread quickly enough. It's also slow. > > Listen and accept in the main thread, and start the connect thread in > between. Look ma, no sleep! Run time drops from 2s wall clock to a > few milliseconds. > > Signed-off-by: Markus Armbruster <[email protected]> > --- > tests/test-util-sockets.c | 39 +++++++++++++-------------------------- > 1 file changed, 13 insertions(+), 26 deletions(-) > Reviewed-by: Eric Blake <[email protected]> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
