On Tue, 13 Oct 2020 at 18:10, Richard Henderson <[email protected]> wrote: > > On 10/12/20 12:56 PM, Peter Maydell wrote: > > On Mon, 12 Oct 2020 at 16:37, Peter Maydell <[email protected]> > > wrote: > > This turns out not to work, because gen_jmp() always generates > > a goto-tb for tb exit 0, and we hit the assert() that exit 0 > > was not used twice. Here's a fixup to fold into this patch: > > Indeed. I was going to suggest that here you should use arm_gen_condlabel() > like you did for LE. Which I think would be still cleaner than your fixup > patch.
I thought about that but it doesn't really fit, because the condlabel is for "go to the next instruction without having done anything". Here we need to do something on that codepath (unlike LE). thanks -- PMM
