On Tue, 25 Aug 2020 at 12:26, Chen Qun <[email protected]> wrote: > > Clang static code analyzer show warning: > target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' during > its > initialization is never read > TCGv_i64 tcg_rn = new_tmp_a64(s); > ^~~~~~ ~~~~~~~~~~~~~~ > target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd' during > its > initialization is never read > TCGv_i64 tcg_rd = new_tmp_a64(s); > ^~~~~~ ~~~~~~~~~~~~~~ > > There is a memory leak for the variable new_tmp_a64 "s".
There is not, because TCG temps allocated via new_tmp_a64() are all freed via free_tmp_a64() at the end of disas_a64_insn(). > We should delete the assignment. But yes, the assignments are unused and should be deleted. If you fix the commit message, then Reviewed-by: Peter Maydell <[email protected]> thanks -- PMM
