Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529134523.8477-1-arm...@redhat.com Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 439fb47 MAINTAINERS: Make section QOM cover hw/core/*bus.c as well d92f0c7 qdev: qdev_init_nofail() is now unused, drop c0715ef qdev: Convert bus-less devices to qdev_realize() with Coccinelle 66e45b5 qdev: Use qdev_realize() in qdev_device_add() 432aa71 qdev: Make qdev_realize() support bus-less devices 7adde43 s390x/event-facility: Simplify creation of SCLP event devices 023393d microbit: Eliminate two local variables in microbit_init() d32d183 sysbus: sysbus_init_child_obj() is now unused, drop f887b4a sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4 a48b36e sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3 16d53b8 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 a0a8667 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 1cccb08 qdev: Drop qdev_realize() support for null bus 1f150da sysbus: Convert to sysbus_realize() etc. with Coccinelle 515e6be sysbus: New sysbus_realize(), sysbus_realize_and_unref() 0409a9e sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2 2c443b6 hw/arm/armsse: Pass correct child size to sysbus_init_child_obj() 2ed1734 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1 9325ac9 microbit: Tidy up sysbus_init_child_obj() @child argument b7ac15d sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls 5dc614e macio: Eliminate macio_init_child_obj() bc90f43 macio: Convert use of qdev_set_parent_bus() 2196060 qom: Less verbose object_initialize_child() 96f3e31 qom: Tidy up a few object_initialize_child() calls 0820cdc auxbus: Eliminate aux_create_slave() 4a021fb auxbus: Convert a use of qdev_set_parent_bus() bbc4f64 auxbus: New aux_bus_realize(), pairing with aux_bus_init() 52256c6 auxbus: Rename aux_init_bus() to aux_bus_init() 76048e4 qdev: qdev_create(), qdev_try_create() are now unused, drop 6374c40 usb: Eliminate usb_try_create_simple() 7c5c5ab usb: usb_create() is now unused, drop a43f9f0 usb: Convert uses of usb_create() a4c114f usb: New usb_new(), usb_realize_and_unref() cb5a489 ssi: ssi_create_slave_no_init() is now unused, drop db5290e ssi: Convert last use of ssi_create_slave_no_init() manually c9a8764 ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle 9545fd0 ssi: ssi_auto_connect_slaves() never does anything, drop 14e4080 isa: isa_create(), isa_try_create() are now unused, drop a54d8a1 isa: Convert uses of isa_create(), isa_try_create() manually 2631eed isa: Convert uses of isa_create() with Coccinelle 021d395 isa: New isa_new(), isa_realize_and_unref() etc. eb88940 pci: pci_create(), pci_create_multifunction() are now unused, drop 56f3abb pci: Convert uses of pci_create() etc. manually bd6368c pci: Convert uses of pci_create() etc. with Coccinelle 60ce491 hw/ppc: Eliminate two superfluous QOM casts a64f284 pci: New pci_new(), pci_realize_and_unref() etc. f88aed3 qdev: Convert uses of qdev_set_parent_bus() manually 7a73579 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle e793be8 qdev: Convert uses of qdev_create() manually 1e16c91 qdev: Convert uses of qdev_create() with Coccinelle 079098b qdev: Convert to qdev_unrealize() manually a68857c qdev: Convert to qdev_unrealize() with Coccinelle 1278ec6 qdev: Convert to qbus_realize(), qbus_unrealize() f7515ac qdev: Put qdev_new() to use with Coccinelle 30e7237 qdev: New qdev_new(), qdev_realize(), etc. ebddc9d Revert "hw/versatile: realize the PCI root bus as part of the versatile init" ae55003 Revert "hw/prep: realize the PCI root bus as part of the prep init" 1d4911c qdev: Rename qbus_realize() to qbus_init() === OUTPUT BEGIN === 1/58 Checking commit 1d4911ccb8d0 (qdev: Rename qbus_realize() to qbus_init()) 2/58 Checking commit ae55003b5a47 (Revert "hw/prep: realize the PCI root bus as part of the prep init") 3/58 Checking commit ebddc9d7a53c (Revert "hw/versatile: realize the PCI root bus as part of the versatile init") 4/58 Checking commit 30e7237d2b7e (qdev: New qdev_new(), qdev_realize(), etc.) 5/58 Checking commit f7515ac8f5b7 (qdev: Put qdev_new() to use with Coccinelle) 6/58 Checking commit 1278ec63328a (qdev: Convert to qbus_realize(), qbus_unrealize()) 7/58 Checking commit a68857c8ae4b (qdev: Convert to qdev_unrealize() with Coccinelle) 8/58 Checking commit 079098b4361c (qdev: Convert to qdev_unrealize() manually) 9/58 Checking commit 1e16c91bd20c (qdev: Convert uses of qdev_create() with Coccinelle) 10/58 Checking commit e793be88432b (qdev: Convert uses of qdev_create() manually) 11/58 Checking commit 7a73579f06a8 (qdev: Convert uses of qdev_set_parent_bus() with Coccinelle) 12/58 Checking commit f88aed37101f (qdev: Convert uses of qdev_set_parent_bus() manually) 13/58 Checking commit a64f284c5096 (pci: New pci_new(), pci_realize_and_unref() etc.) 14/58 Checking commit 60ce491ff2c9 (hw/ppc: Eliminate two superfluous QOM casts) 15/58 Checking commit bd6368cea83a (pci: Convert uses of pci_create() etc. with Coccinelle) 16/58 Checking commit 56f3abb79412 (pci: Convert uses of pci_create() etc. manually) 17/58 Checking commit eb889403b14d (pci: pci_create(), pci_create_multifunction() are now unused, drop) 18/58 Checking commit 021d3950d2cd (isa: New isa_new(), isa_realize_and_unref() etc.) 19/58 Checking commit 2631eed1a06d (isa: Convert uses of isa_create() with Coccinelle) ERROR: do not use C99 // comments #384: FILE: hw/rtc/m48t59-isa.c:74: + ISADevice *isa_dev; // TODO move ERROR: do not use C99 // comments #420: FILE: hw/sparc64/sun4u.c:341: + ISADevice *isa_dev; // TODO move total: 2 errors, 0 warnings, 348 lines checked Patch 19/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/58 Checking commit a54d8a1d99f6 (isa: Convert uses of isa_create(), isa_try_create() manually) 21/58 Checking commit 14e4080810d0 (isa: isa_create(), isa_try_create() are now unused, drop) 22/58 Checking commit 9545fd066aff (ssi: ssi_auto_connect_slaves() never does anything, drop) 23/58 Checking commit c9a87646ee76 (ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle) 24/58 Checking commit db5290e971d1 (ssi: Convert last use of ssi_create_slave_no_init() manually) 25/58 Checking commit cb5a489800c6 (ssi: ssi_create_slave_no_init() is now unused, drop) 26/58 Checking commit a4c114f899d2 (usb: New usb_new(), usb_realize_and_unref()) 27/58 Checking commit a43f9f03ebad (usb: Convert uses of usb_create()) 28/58 Checking commit 7c5c5abcf5df (usb: usb_create() is now unused, drop) 29/58 Checking commit 6374c40d97d6 (usb: Eliminate usb_try_create_simple()) 30/58 Checking commit 76048e4a9462 (qdev: qdev_create(), qdev_try_create() are now unused, drop) 31/58 Checking commit 52256c61e373 (auxbus: Rename aux_init_bus() to aux_bus_init()) 32/58 Checking commit bbc4f6453b6c (auxbus: New aux_bus_realize(), pairing with aux_bus_init()) 33/58 Checking commit 4a021fb34d94 (auxbus: Convert a use of qdev_set_parent_bus()) 34/58 Checking commit 0820cdc01f86 (auxbus: Eliminate aux_create_slave()) 35/58 Checking commit 96f3e313c91e (qom: Tidy up a few object_initialize_child() calls) 36/58 Checking commit 2196060b2590 (qom: Less verbose object_initialize_child()) 37/58 Checking commit bc90f43e93a9 (macio: Convert use of qdev_set_parent_bus()) 38/58 Checking commit 5dc614ecab3d (macio: Eliminate macio_init_child_obj()) 39/58 Checking commit b7ac15d209f7 (sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls) WARNING: line over 80 characters #144: FILE: hw/arm/aspeed_ast2600.c:221: + &s->emmc.slots[0], sizeof(s->emmc.slots[0]), TYPE_SYSBUS_SDHCI); total: 0 errors, 1 warnings, 238 lines checked Patch 39/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/58 Checking commit 9325ac93a7b1 (microbit: Tidy up sysbus_init_child_obj() @child argument) 41/58 Checking commit 2ed17344e8fc (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1) 42/58 Checking commit 2c443b60ec07 (hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()) 43/58 Checking commit 0409a9efa3a3 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2) 44/58 Checking commit 515e6bed1aa3 (sysbus: New sysbus_realize(), sysbus_realize_and_unref()) 45/58 Checking commit 1f150dabc41d (sysbus: Convert to sysbus_realize() etc. with Coccinelle) 46/58 Checking commit 1cccb0836d4c (qdev: Drop qdev_realize() support for null bus) 47/58 Checking commit a0a8667410c3 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1) 48/58 Checking commit 16d53b8bc144 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2) 49/58 Checking commit a48b36e90d91 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3) 50/58 Checking commit f887b4a113ed (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4) 51/58 Checking commit d32d183e22e3 (sysbus: sysbus_init_child_obj() is now unused, drop) 52/58 Checking commit 023393df5a26 (microbit: Eliminate two local variables in microbit_init()) 53/58 Checking commit 7adde438cbf4 (s390x/event-facility: Simplify creation of SCLP event devices) 54/58 Checking commit 432aa713c9ec (qdev: Make qdev_realize() support bus-less devices) 55/58 Checking commit 66e45b562e1b (qdev: Use qdev_realize() in qdev_device_add()) 56/58 Checking commit c0715ef52295 (qdev: Convert bus-less devices to qdev_realize() with Coccinelle) 57/58 Checking commit d92f0c7b4477 (qdev: qdev_init_nofail() is now unused, drop) 58/58 Checking commit 439fb47776fd (MAINTAINERS: Make section QOM cover hw/core/*bus.c as well) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200529134523.8477-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
