Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529134523.8477-1-arm...@redhat.com Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200529134523.8477-1-arm...@redhat.com -> patchew/20200529134523.8477-1-arm...@redhat.com Switched to a new branch 'test' 7589916 MAINTAINERS: Make section QOM cover hw/core/*bus.c as well 6994d03 qdev: qdev_init_nofail() is now unused, drop 28e5350 qdev: Convert bus-less devices to qdev_realize() with Coccinelle 24d6e87 qdev: Use qdev_realize() in qdev_device_add() 69431f7 qdev: Make qdev_realize() support bus-less devices eacf47b s390x/event-facility: Simplify creation of SCLP event devices aa49280 microbit: Eliminate two local variables in microbit_init() f0de8f0 sysbus: sysbus_init_child_obj() is now unused, drop 66f9bee sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4 1331f49 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3 5fa2c01 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 0ccb25e sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 961ce94 qdev: Drop qdev_realize() support for null bus d78366f sysbus: Convert to sysbus_realize() etc. with Coccinelle 898a7ab sysbus: New sysbus_realize(), sysbus_realize_and_unref() 0fbbe51 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2 860c6ca hw/arm/armsse: Pass correct child size to sysbus_init_child_obj() 162f9dc sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1 b99d804 microbit: Tidy up sysbus_init_child_obj() @child argument ff62f9e sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls e53941f macio: Eliminate macio_init_child_obj() 2510ca8 macio: Convert use of qdev_set_parent_bus() 953f19f qom: Less verbose object_initialize_child() 8778bdb qom: Tidy up a few object_initialize_child() calls abb885b auxbus: Eliminate aux_create_slave() 5083fdd auxbus: Convert a use of qdev_set_parent_bus() e8a1b07 auxbus: New aux_bus_realize(), pairing with aux_bus_init() c1752eb auxbus: Rename aux_init_bus() to aux_bus_init() c1dadd3 qdev: qdev_create(), qdev_try_create() are now unused, drop 39bd923 usb: Eliminate usb_try_create_simple() 37db777 usb: usb_create() is now unused, drop e5fc764 usb: Convert uses of usb_create() edb4e6f usb: New usb_new(), usb_realize_and_unref() c201e80 ssi: ssi_create_slave_no_init() is now unused, drop 153b1f5 ssi: Convert last use of ssi_create_slave_no_init() manually 27662fe ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle fda3da1 ssi: ssi_auto_connect_slaves() never does anything, drop 1bf6c3d isa: isa_create(), isa_try_create() are now unused, drop f318e5e isa: Convert uses of isa_create(), isa_try_create() manually 0895b2f isa: Convert uses of isa_create() with Coccinelle f974cfd isa: New isa_new(), isa_realize_and_unref() etc. 606ba5d pci: pci_create(), pci_create_multifunction() are now unused, drop a5c13fa pci: Convert uses of pci_create() etc. manually c35c770 pci: Convert uses of pci_create() etc. with Coccinelle 5464c8e hw/ppc: Eliminate two superfluous QOM casts 5d67e72 pci: New pci_new(), pci_realize_and_unref() etc. cc45810 qdev: Convert uses of qdev_set_parent_bus() manually 46e1328 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle 67f0f5e qdev: Convert uses of qdev_create() manually 0a1d4ce qdev: Convert uses of qdev_create() with Coccinelle 27f7460 qdev: Convert to qdev_unrealize() manually 2498182 qdev: Convert to qdev_unrealize() with Coccinelle ad3110b qdev: Convert to qbus_realize(), qbus_unrealize() 25b4418 qdev: Put qdev_new() to use with Coccinelle ed7f4e6 qdev: New qdev_new(), qdev_realize(), etc. 6f19dca Revert "hw/versatile: realize the PCI root bus as part of the versatile init" c59bc88 Revert "hw/prep: realize the PCI root bus as part of the prep init" ebbe306 qdev: Rename qbus_realize() to qbus_init() === OUTPUT BEGIN === 1/58 Checking commit ebbe306db75f (qdev: Rename qbus_realize() to qbus_init()) 2/58 Checking commit c59bc8873b47 (Revert "hw/prep: realize the PCI root bus as part of the prep init") 3/58 Checking commit 6f19dca18669 (Revert "hw/versatile: realize the PCI root bus as part of the versatile init") 4/58 Checking commit ed7f4e69bb18 (qdev: New qdev_new(), qdev_realize(), etc.) 5/58 Checking commit 25b4418f5f7a (qdev: Put qdev_new() to use with Coccinelle) 6/58 Checking commit ad3110b90bac (qdev: Convert to qbus_realize(), qbus_unrealize()) 7/58 Checking commit 2498182f99c4 (qdev: Convert to qdev_unrealize() with Coccinelle) 8/58 Checking commit 27f74605f6cd (qdev: Convert to qdev_unrealize() manually) 9/58 Checking commit 0a1d4ce8a9e8 (qdev: Convert uses of qdev_create() with Coccinelle) 10/58 Checking commit 67f0f5e99ac1 (qdev: Convert uses of qdev_create() manually) 11/58 Checking commit 46e13283fb42 (qdev: Convert uses of qdev_set_parent_bus() with Coccinelle) 12/58 Checking commit cc4581055d6a (qdev: Convert uses of qdev_set_parent_bus() manually) 13/58 Checking commit 5d67e7231d7a (pci: New pci_new(), pci_realize_and_unref() etc.) 14/58 Checking commit 5464c8e9092a (hw/ppc: Eliminate two superfluous QOM casts) 15/58 Checking commit c35c7705d264 (pci: Convert uses of pci_create() etc. with Coccinelle) 16/58 Checking commit a5c13fae7b97 (pci: Convert uses of pci_create() etc. manually) 17/58 Checking commit 606ba5dd2307 (pci: pci_create(), pci_create_multifunction() are now unused, drop) 18/58 Checking commit f974cfde8a96 (isa: New isa_new(), isa_realize_and_unref() etc.) 19/58 Checking commit 0895b2f7bdef (isa: Convert uses of isa_create() with Coccinelle) ERROR: do not use C99 // comments #384: FILE: hw/rtc/m48t59-isa.c:74: + ISADevice *isa_dev; // TODO move ERROR: do not use C99 // comments #420: FILE: hw/sparc64/sun4u.c:341: + ISADevice *isa_dev; // TODO move total: 2 errors, 0 warnings, 348 lines checked Patch 19/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/58 Checking commit f318e5e73fec (isa: Convert uses of isa_create(), isa_try_create() manually) 21/58 Checking commit 1bf6c3dff63d (isa: isa_create(), isa_try_create() are now unused, drop) 22/58 Checking commit fda3da1972d0 (ssi: ssi_auto_connect_slaves() never does anything, drop) 23/58 Checking commit 27662fe7b4ea (ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle) 24/58 Checking commit 153b1f5ffd90 (ssi: Convert last use of ssi_create_slave_no_init() manually) 25/58 Checking commit c201e80d6131 (ssi: ssi_create_slave_no_init() is now unused, drop) 26/58 Checking commit edb4e6f9e243 (usb: New usb_new(), usb_realize_and_unref()) 27/58 Checking commit e5fc7646c036 (usb: Convert uses of usb_create()) 28/58 Checking commit 37db777adfa9 (usb: usb_create() is now unused, drop) 29/58 Checking commit 39bd92331d31 (usb: Eliminate usb_try_create_simple()) 30/58 Checking commit c1dadd39f82f (qdev: qdev_create(), qdev_try_create() are now unused, drop) 31/58 Checking commit c1752ebd01d4 (auxbus: Rename aux_init_bus() to aux_bus_init()) 32/58 Checking commit e8a1b07a0960 (auxbus: New aux_bus_realize(), pairing with aux_bus_init()) 33/58 Checking commit 5083fdd2e26f (auxbus: Convert a use of qdev_set_parent_bus()) 34/58 Checking commit abb885b7ec3a (auxbus: Eliminate aux_create_slave()) 35/58 Checking commit 8778bdb31982 (qom: Tidy up a few object_initialize_child() calls) 36/58 Checking commit 953f19fdd985 (qom: Less verbose object_initialize_child()) 37/58 Checking commit 2510ca882185 (macio: Convert use of qdev_set_parent_bus()) 38/58 Checking commit e53941fbcd33 (macio: Eliminate macio_init_child_obj()) 39/58 Checking commit ff62f9e7764d (sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls) WARNING: line over 80 characters #144: FILE: hw/arm/aspeed_ast2600.c:221: + &s->emmc.slots[0], sizeof(s->emmc.slots[0]), TYPE_SYSBUS_SDHCI); total: 0 errors, 1 warnings, 238 lines checked Patch 39/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/58 Checking commit b99d804dd0f8 (microbit: Tidy up sysbus_init_child_obj() @child argument) 41/58 Checking commit 162f9dc4176c (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1) 42/58 Checking commit 860c6caf648f (hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()) 43/58 Checking commit 0fbbe51261c9 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2) 44/58 Checking commit 898a7ab1aee0 (sysbus: New sysbus_realize(), sysbus_realize_and_unref()) 45/58 Checking commit d78366f9a62c (sysbus: Convert to sysbus_realize() etc. with Coccinelle) 46/58 Checking commit 961ce942b6d4 (qdev: Drop qdev_realize() support for null bus) 47/58 Checking commit 0ccb25e7eb0d (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1) 48/58 Checking commit 5fa2c01d63f8 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2) 49/58 Checking commit 1331f492e7b5 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3) 50/58 Checking commit 66f9bee437db (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4) 51/58 Checking commit f0de8f06c917 (sysbus: sysbus_init_child_obj() is now unused, drop) 52/58 Checking commit aa492801367a (microbit: Eliminate two local variables in microbit_init()) 53/58 Checking commit eacf47bc6f85 (s390x/event-facility: Simplify creation of SCLP event devices) 54/58 Checking commit 69431f780e1e (qdev: Make qdev_realize() support bus-less devices) 55/58 Checking commit 24d6e876b29a (qdev: Use qdev_realize() in qdev_device_add()) 56/58 Checking commit 28e53504bf09 (qdev: Convert bus-less devices to qdev_realize() with Coccinelle) 57/58 Checking commit 6994d038b2b4 (qdev: qdev_init_nofail() is now unused, drop) 58/58 Checking commit 7589916c0ae5 (MAINTAINERS: Make section QOM cover hw/core/*bus.c as well) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200529134523.8477-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
